This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Improve focus styles for audio subcomponents #459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
added
✨ goal: improvement
Improvement to an existing user-facing feature
🕹 aspect: interface
Concerns end-users' experience with the software
🟨 priority: medium
Not blocking but should be addressed soon
labels
Nov 30, 2021
dhruvkb
force-pushed
the
audio_layouts
branch
from
November 30, 2021 13:52
7d109c0
to
38528d6
Compare
dhruvkb
changed the title
Improve focus styles for audio subcomponents and refactor layouts to support responsive switching
Improve focus styles for audio subcomponents
Dec 3, 2021
Reducing the scope of this PR to make this more mergeable. |
dhruvkb
force-pushed
the
audio_layouts
branch
from
December 3, 2021 17:23
75d1f7c
to
cd5dc27
Compare
zackkrida
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zackkrida the |
krysal
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements here ✨
krysal
reviewed
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🕹 aspect: interface
Concerns end-users' experience with the software
✨ goal: improvement
Improvement to an existing user-facing feature
🟨 priority: medium
Not blocking but should be addressed soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #407 by @dhruvkb
Description
This PR
Testing Instructions
Check out the branch and run the Storybook.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin