Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Improve focus styles for audio subcomponents #459

Merged
merged 8 commits into from
Dec 8, 2021
Merged

Improve focus styles for audio subcomponents #459

merged 8 commits into from
Dec 8, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 30, 2021

Fixes

Fixes #407 by @dhruvkb

Description

This PR

  • improves the focus styles for audio-track sub components
  • cleans up and refactors the audio-track layouts to ease the addition of new ones
  • makes general code quality improvements such as reduced duplication and improved documentation

Testing Instructions

Check out the branch and run the Storybook.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Nov 30, 2021
@dhruvkb dhruvkb changed the title Improve focus styles for audio subcomponents and refactor layouts to support responsive switching Improve focus styles for audio subcomponents Dec 3, 2021
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 3, 2021

Reducing the scope of this PR to make this more mergeable.

@dhruvkb dhruvkb marked this pull request as ready for review December 3, 2021 13:03
@dhruvkb dhruvkb requested a review from a team as a code owner December 3, 2021 13:03
@dhruvkb dhruvkb requested review from krysal and obulat December 3, 2021 13:03
@zackkrida zackkrida added this to the Redesign milestone Dec 3, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimizations. Outside of some small style suggestions, I noticed that the waveform is missing on this page:

CleanShot 2021-12-06 at 10 46 21@2x

I can't see the problem in the code, so I'm not sure if it's intentional or not.

src/components/AudioTrack/PlayPause.vue Show resolved Hide resolved
src/constants/screens.js Show resolved Hide resolved
tailwind.config.js Show resolved Hide resolved
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 7, 2021

@zackkrida the AudioTrack with the missing waveform might be the Row S layout of the component, you can see it by toggling the filters sidebar.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements here ✨

@dhruvkb dhruvkb merged commit 630e295 into main Dec 8, 2021
@dhruvkb dhruvkb deleted the audio_layouts branch December 8, 2021 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve focus styles on AudioTrack subcomponents
3 participants