This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the
InputField
andSearchBar
components #380Create the
InputField
andSearchBar
components #380Changes from 16 commits
3ae1f2a
c0d9876
4ca2feb
a34763d
915c02c
72c9500
aa36b88
5571c16
4b2494a
66e4f50
8c655d6
eb90e67
dbf59de
734a73f
b7fef48
b65f224
b768fc3
ea8fe74
9175908
cce3148
4582019
34a0053
e081937
f06e44e
a7d1e98
b34a843
c7f8032
ef73c50
0d9cbce
894d43d
be2b67f
616400a
cc1ab67
447a973
61687b6
b8e9084
76a97e1
5e6dc7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this? It's especially useful on mobile.
cc @panchovm
Also the way these styles are applied means they will be applied globally. We should use either
scoped
ormodule
and associate these modifications to a specific class at the very least.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be scoped because the input-field being styled is in a different component. But made the selector more "selective" in a7d1e98.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, I still think we should make sure removing it is the right choice. Why are we removing it? The button is especially useful on mobile devices where selecting the contents of an input isn't necessarily easy across devices (even my iPhone 12 Pro Max doesn't do a good job of selecting input fields to make it easy to copy or clear them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the utility of the clear button on phones. It's good from a usability perspective. My main complaint against it was that it also appears on desktops, where its utility is doubtful. I'll let @panchovm take the call on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I am confused, what are we removing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I understand, sorry for the confusion. The clear action never was in the redesign, but you are right; it adds so much value to the search experience. I will work on adding it to the Design Library's components.