Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix undefined "type" in LicenseExplanationTooltip #294

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

sarayourfriend
Copy link
Contributor

Description

Hotfix to resolve an issue with the frontend crashing on start due to a typo in a "type" definition for a prop.

Introduced by 180452b

Testing Instructions

Run npm run dev locally and verify the app starts.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 6, 2021
@sarayourfriend sarayourfriend requested a review from a team as a code owner October 6, 2021 14:58
@zackkrida
Copy link
Member

Going to merge this hotfix, another @WordPress/openverse-developers can do a quick retroactive review. Thanks @sarayourfriend 👍

@zackkrida zackkrida merged commit 4d50ea1 into main Oct 6, 2021
@zackkrida zackkrida deleted the fix/license-expl-icon-type branch October 6, 2021 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants