Write tests for search-store

[obulat]

Fixes

Fixes #285 by @obulat

Description

This PR adds tests for search-store and raises the coverage to 100%.

This PR also removes the actions for fetching collection images because they are not used anywhere. If needed, they can be re-added in the future.

To make adding media types easier, actions are created using an object now:
instead of actions(audioService, imageService),
they use a services object:
services = { 'audio': audioService, 'image': imageService }.

A couple of small bugs were also fixed:

• MEDIA_NOT_FOUND is called correctly, using both state and params as parameters.
• in FETCH_AUDIO, the usageSessionId is set correctly, using the namespaced user.usageSessionId
• only the search page watches for query changes, and updates the media in Vuex store, instead of both search page and SearchGridManualLoad. I've reverted this change

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

LGTM aside from the expect().rejects issue I pointed out in a few places. Otherwise once those are addressed this will be a nice addition to the test suite 😁

[sarayourfriend]

LGTM! 🚀

[obulat]

I also added a bug-fix in here: both SearchGridManualLoad and search page were watching the query and updating the media in store on change. It is enough to watch for query changes on the search page. To make sure that all changes in query trigger the watcher, I added the deep: true to the watcher.

[sarayourfriend]

@obulat Now that there are some changes outside of adding tests can you add testing instructions?

[obulat]

@obulat Now that there are some changes outside of adding tests can you add testing instructions?

There was previously a bug when on a Search Form submit (clicking Search button) you would get all the query parameters in URL, even if they were blank: openverse/search/images?q=&license=&license_type=&, and I was trying to fix it with some small changes. But I don't see this bug anymore, I have no idea why! So, I just reverted the changes to only contain the Search store tests, and two small bug fixes, that you've already seen and approved, @sarayourfriend . Sorry for so much back-and-forth on this PR

[sarayourfriend]

LGTM! No worries about the back and forth 😅

[zackkrida]

🥳