Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add ImageGrid component and use it for RelatedImages #281

Merged
merged 14 commits into from
Oct 8, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 1, 2021

Fixes

Related #280 by @obulat

Description

This PR extracts the functionality of SearchGridManualLoad that has to do with displaying images and an optional Load more button into a new ImageGrid component.
RelatedImages component is refactored to be responsible for fetching related images, and use ImageGrid to display them. This makes the images part of related Vuex store unnecessary, and also simplifies the Vuex isFetching and isFetchingError states: now they are only changed by Image search and Single image result [which should actually control its state separately].

I think the SearchGrid component will also need to be refactored to use the ImageGrid component later.
The ImageCell is copied as-is from the SearchGridCell to ensure that possible changes later do not introduce unwanted bugs.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner October 1, 2021 16:26
@obulat obulat requested review from zackkrida and krysal October 1, 2021 16:26
@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 1, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. There used to be such an irritating bug where if loading related images failed, the site would show related images from the previous image, due to these being held in a global store.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now these components seem more in line with the "Single-responsibility principle". Awesome!

src/components/AudioDetails/Related.vue Show resolved Hide resolved
src/components/ImageDetails/RelatedImages.vue Outdated Show resolved Hide resolved
obulat and others added 3 commits October 6, 2021 06:41
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love getting rid of global state 🎉 I'm running into some local dev issues so I can't test it though 😢

test/unit/specs/components/related-images.spec.js Outdated Show resolved Hide resolved
test/unit/specs/components/related-images.spec.js Outdated Show resolved Hide resolved
test/unit/specs/components/image-grid.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@obulat obulat merged commit 62d20fd into main Oct 8, 2021
@obulat obulat deleted the image_grid_component branch October 8, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants