This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Extract tabs styles #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackkrida
added
♿️ aspect: a11y
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts tab styles into a separate file from the three components where they are used:
CopyLicensePhotoDetailsSearchTypeTabsIt also adds necessary a11y properties to the search sub-pages which are opened as tab-panels.
This code change will prepare the code for extraction of Vocabulary and bulma code.
The main class is called
search-tabinstead oftabso that bulma styles do not interfere with the styles we use.