This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
test/unit/specs/components/ImageDetails/image-attribution.spec.js
Outdated
Show resolved
Hide resolved
obulat
reviewed
Sep 24, 2021
obulat
suggested changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
There are several changes I've added inline: it's better to finish renaming ccLicenseUrl
to openverseLicenseUrl
, and rename prop names, as well as values.
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
Co-authored-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: Olga Bulat <obulat@gmail.com>
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
obulat
reviewed
Sep 24, 2021
test/unit/specs/components/ImageDetails/image-attribution.spec.js
Outdated
Show resolved
Hide resolved
obulat
reviewed
Sep 24, 2021
obulat
approved these changes
Sep 24, 2021
zackkrida
approved these changes
Sep 24, 2021
Thank you @theshakeabhi ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #254 by @dhruvkb
Description
This PR would make the prop name uniform across the code base by changing the non-camelcase to camel case.
For now these changes has been made across the code base:
ccLicenseURL to ccLicenseUrl
licenseURL to licenseUrl
openverseLicenseURL to openverseLicenseUrl
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin