Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Url camelcase fix #262

Merged
merged 23 commits into from
Sep 28, 2021
Merged

Url camelcase fix #262

merged 23 commits into from
Sep 28, 2021

Conversation

theshakeabhi
Copy link
Contributor

Fixes

Fixes #254 by @dhruvkb

Description

This PR would make the prop name uniform across the code base by changing the non-camelcase to camel case.
For now these changes has been made across the code base:
ccLicenseURL to ccLicenseUrl
licenseURL to licenseUrl
openverseLicenseURL to openverseLicenseUrl

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@theshakeabhi theshakeabhi requested a review from a team as a code owner September 24, 2021 06:44
@obulat obulat changed the title Url camecase fix Url camelcase fix Sep 24, 2021
src/pages/audio/_id.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
There are several changes I've added inline: it's better to finish renaming ccLicenseUrl to openverseLicenseUrl, and rename prop names, as well as values.

src/assets/fonts/VocabularyIcons.json Outdated Show resolved Hide resolved
@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix labels Sep 24, 2021
Co-authored-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: Olga Bulat <obulat@gmail.com>
src/pages/audio/_id.vue Outdated Show resolved Hide resolved
src/pages/audio/_id.vue Outdated Show resolved Hide resolved
src/pages/audio/_id.vue Outdated Show resolved Hide resolved
@zackkrida zackkrida merged commit 8ebe51f into WordPress:main Sep 28, 2021
@zackkrida
Copy link
Member

Thank you @theshakeabhi !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Use camelcase in prop names
3 participants