Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Linting and formatting hotfixes for AudioTrack Row #257

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Linting and formatting hotfixes for AudioTrack Row #257

merged 4 commits into from
Sep 23, 2021

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Sep 23, 2021 •
edited
Loading

Fixes checks passing on the main branch. Not sure how this lint warning snuck through, but in any case it's a quick fix.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner September 23, 2021 15:53
@zackkrida zackkrida added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix labels Sep 23, 2021
dhruvkb
dhruvkb suggested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should separator character be internationalised? Might cultures have different interpretations of the interpunct?

src/components/AudioTrack/layouts/Row.vue Show resolved Hide resolved
src/components/AudioTrack/layouts/Row.vue Outdated Show resolved Hide resolved
@zackkrida zackkrida requested a review from dhruvkb September 23, 2021 16:26
sarayourfriend
sarayourfriend approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/locales/en.json
@@ -639,5 +639,6 @@
"intro": "CC Search is now called Openverse and joins WordPress as an open source project.",
"more": "{read-more} about this announcement.",
"read": "Read more"
}
},
"interpunct": "•"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add translators comments for this? It might be helpful for something this specific to give the context of where it is used without the translators having to interpret the template code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a good way to add comments yet sadly. Need to think about the best way to support it. I can ask some i18n folks about of we should do this though before we push

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believed this was merely an aesthetic detail rather than something that needed translation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to allow it to be translated... for example in Eastern Arabic, Persian and Urdu numerals the interpunct looks very similar to the notation for 0, "٠", which could be confusing given that this separates the timestamp from the rest of the text surrounding it.

@zackkrida
Copy link
Member Author

This is ready for re-review as well @dhruvkb if you didn't see. Thanks!

dhruvkb
dhruvkb approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's good, except for one typo.

src/components/AudioTrack/layouts/Row.vue Outdated Show resolved Hide resolved
dhruvkb
dhruvkb reviewed Sep 23, 2021
View reviewed changes
src/components/AudioTrack/layouts/Row.vue Outdated
@@ -77,8 +79,8 @@ export default {
const isSmall = computed(() => props.size === 's')

return {
seperator: this.$t('interpunct'),
Copy link
Member

@dhruvkb dhruvkb Sep 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also using $t without computed(() => {}) will not be reactive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yep. will fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I can't figure out how to use i18n with the composition api 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put the $t inside the template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooh, thanks. super easy 😄

@zackkrida zackkrida requested a review from dhruvkb September 23, 2021 17:46
krysal
krysal approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@zackkrida zackkrida merged commit 8a1e75a into main Sep 23, 2021
@zackkrida zackkrida deleted the frontend-hotfixes branch September 23, 2021 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@krysal krysal krysal approved these changes

@obulat obulat Awaiting requested review from obulat

@dhruvkb dhruvkb Awaiting requested review from dhruvkb

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zackkrida @krysal @dhruvkb @sarayourfriend