Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Updated URL ref parameter values for analytics for PhotoDetails.vue #253

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

MuhammadFaizanHaidar
Copy link
Contributor

Replace ccsearch with openverse
issue track: #181

Fixes

Fixes #181 by @obulat

Description

Replaces ref=ccsearch with ref=openverse

Screenshots

ccsearchtoopenverse

Technical details

Updated URL ref parameter values for analytics.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MuhammadFaizanHaidar MuhammadFaizanHaidar requested a review from a team as a code owner September 22, 2021 12:02
@MuhammadFaizanHaidar MuhammadFaizanHaidar changed the title Updated URL ref parameter values for analytics Updated URL ref parameter values for analytics for PhotoDetails.vue Sep 22, 2021
@MuhammadFaizanHaidar
Copy link
Contributor Author

Can someone please tell why PR label checks are getting failed. Is this because I made two PR's to some issue? Although their titles are different. Thanks

@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Sep 22, 2021
@obulat
Copy link
Contributor

obulat commented Sep 22, 2021

Can someone please tell why PR label checks are getting failed. Is this because I made two PR's to some issue? Although their titles are different. Thanks

To simplify creating the changelog, we have a script in the repository that checks if you have applied relevant tags to your PR. At least one of the aspect:<> and one of the goal:<> labels need to be applied. I've added the labels, so the checks pass now.

@MuhammadFaizanHaidar
Copy link
Contributor Author

Can someone please tell why PR label checks are getting failed. Is this because I made two PR's to some issue? Although their titles are different. Thanks

@obulat I can see 2 other files using ccLicenseUrl as a prop.

  1. ImageAttributes.vue
  2. ImageInfo.vue

@obulat
Copy link
Contributor

obulat commented Sep 23, 2021

This changes should be enough to ensure that the ref parameter is correct. We will change the prop names in future PRs. Thank you for your contribution, @MuhammadFaizanHaidar !

@obulat obulat merged commit ed338e8 into WordPress:main Sep 23, 2021
@MuhammadFaizanHaidar
Copy link
Contributor Author

This changes should be enough to ensure that the ref parameter is correct. We will change the prop names in future PRs. Thank you for your contribution, @MuhammadFaizanHaidar !

@obulat I am happy that I got a chance to give back to my community!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update URL ref parameter values for analytics
2 participants