Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix Sketchfab viewer sizing #246

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Fix Sketchfab viewer sizing #246

merged 4 commits into from
Sep 23, 2021

Conversation

0kyn
Copy link
Contributor

@0kyn 0kyn commented Sep 20, 2021

Fixes

Fixes #237 by @zackkrida

Description

This PR fixes Sketchfab viewer size, it applies same CSS rules from previous website: http://search.creativecommons.org/photos/6b57230c-6601-476e-a04c-1456d02c9b14

Screenshots

fix_sketchfab_viewer_sizing

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@0kyn 0kyn requested a review from a team as a code owner September 20, 2021 16:15
@0kyn 0kyn requested review from obulat and dhruvkb September 20, 2021 16:15
@krysal krysal added 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 20, 2021
@zackkrida zackkrida self-requested a review September 23, 2021 14:56
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I made a small revision to the css class name and also took this opportunity to update the sketchfab viewer JavaScript to the latest version.

@zackkrida zackkrida merged commit 2c89d59 into WordPress:main Sep 23, 2021
@0kyn 0kyn deleted the fix_sketchfab_viewer branch September 23, 2021 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Sketchfab viewer is too small
3 participants