Fix licence information flyout menu alignment

[0kyn]

Fixes

Fixes #219 by @zackkrida

Description

This PR fixes licence information flyout alignement, it makes tooltip dynamically aligned with licence help icon.

Technical details

Computed CSS properties are calculated once LicenceExplanationTooltip.vue component is mounted.
Some CSS properties related to tooltip box appearance are arbitrary set locally.

Questions

• Is a good practice to get event from computed() methods ?

if (event) {
    const helpIconBounding = event.target.getBoundingClientRect()
    // I'm unclear about this
    // ...
}

• Instead of setting CSS properties into data() method, should it be better to let them defined in <style>...</style> and get them through window.getComputedStyle(this.$el) ?

Screenshots

Desktop

Touch

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

Hi @0kyn apologies for the delay in reviewing this, I will look today and get back to you.

[zackkrida]

Hi @0kyn, I like the approach of setting CSS variables. I made a small change to avoid the computed property event accessing stuff, which I've actually never seen before, to instead pass the dom node of the ? icon to the ToolTip as a prop. I did this by using refs in Vue.

[0kyn]

Hi @zackkrida thanks for the trick! It's pretty interesting, I would never thought about this...

[obulat]

Thank you for fixing the flyout positioning, it works great! I've added a couple of small changes inline, and will approve after they are fixed.

[zackkrida]

@obulat I've gone ahead and applied the requested changes!

Requested changes were applied

[obulat]

Thank you for another great contribution!