Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix the API link in the "Resources" menu dropdown. #234

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

theshakeabhi
Copy link
Contributor

@theshakeabhi theshakeabhi commented Sep 16, 2021

Fixes

Fixes #218 by @zackkrida

Description

Initially the API on the Dropdown of Resources in the Navbar was being directed to https://api.openverse.engineering, now I have redirected it to https://api.openverse.engineering/v1/ as mention on #218 .

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@theshakeabhi theshakeabhi requested a review from a team as a code owner September 16, 2021 18:00
@zackkrida zackkrida added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix labels Sep 16, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the /v1 to the url! There was one more edit needed, switching from creativecommons to openverse. You can commit my suggestions right in the GitHub user interface and I will review again after. Thank you, and welcome to open source 😸

src/components/EmbeddedNavSection.vue Outdated Show resolved Hide resolved
src/components/NavSection.vue Outdated Show resolved Hide resolved
theshakeabhi and others added 2 commits September 16, 2021 23:43
Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Zack Krida <zackkrida@pm.me>
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! And welcome to Openverse 😁 🚀

@theshakeabhi
Copy link
Contributor Author

I got a bit too excited as it was first PR and made those silly mistakes. I will be more aware next time. Thank you @zackkrida for helping me with this issue.

@zackkrida zackkrida merged commit 5259920 into WordPress:main Sep 16, 2021
@theshakeabhi theshakeabhi deleted the nav_link_fix_API branch September 16, 2021 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix nav link to the API
4 participants