Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add "skip to content link" to the Single result pages #2178

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Add "skip to content link" to the Single result pages #2178

merged 3 commits into from
Feb 16, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Feb 13, 2023 •
edited
Loading

Fixes

Related to WordPress/openverse#449 by @obulat

Description

#2175 grew to be too big, so I extracted a part of it into this PR. This PR only deals with the single result pages (image, image/report, audio). It also refactors the VSkipToContentContainer to allow setting its tag to main.

Testing Instructions

The single result pages should have a "Skip to content" link that is the first element on the page that gets focus.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner February 13, 2023 14:40
@obulat obulat requested review from zackkrida and dhruvkb February 13, 2023 14:40
@github-actions
Copy link

github-actions bot commented Feb 13, 2023 •
edited
Loading

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2178
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2178/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 13, 2023
@github-actions
Copy link

github-actions bot commented Feb 13, 2023 •
edited
Loading

Size Change: +3.07 kB (0%)

Total Size: 882 kB

Filename Size Change
./.nuxt/dist/client/components/v-skip-to-content-container.js 911 B +22 B (+2%)
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 918 B +27 B (+3%)
./.nuxt/dist/client/components/v-sources-table.js 16.1 kB +14 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js 16.1 kB +14 B (0%)
./.nuxt/dist/client/pages/audio/_id/index.js 8.39 kB +443 B (+6%) 🔍
./.nuxt/dist/client/pages/audio/_id/index.modern.js 5.25 kB +460 B (+10%) ⚠️
./.nuxt/dist/client/pages/image/_id/index.js 9.7 kB +474 B (+5%) 🔍
./.nuxt/dist/client/pages/image/_id/index.modern.js 7.7 kB +432 B (+6%) 🔍
./.nuxt/dist/client/pages/image/_id/report.js 4.22 kB +626 B (+17%) ⚠️
./.nuxt/dist/client/pages/image/_id/report.modern.js 4.67 kB +469 B (+11%) ⚠️
./.nuxt/dist/client/pages/search.js 5.05 kB +30 B (+1%)
./.nuxt/dist/client/pages/search.modern.js 2.55 kB +30 B (+1%)
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/237.js 273 B 0 B
./.nuxt/dist/client/237.modern.js 277 B 0 B
./.nuxt/dist/client/238.js 1.85 kB 0 B
./.nuxt/dist/client/app.js 141 kB +6 B (0%)
./.nuxt/dist/client/app.modern.js 116 kB +8 B (0%)
./.nuxt/dist/client/commons/app.js 87.7 kB 0 B
./.nuxt/dist/client/commons/app.modern.js 78.1 kB 0 B
./.nuxt/dist/client/components/loading-icon.js 747 B +1 B (0%)
./.nuxt/dist/client/components/loading-icon.modern.js 752 B +1 B (0%)
./.nuxt/dist/client/components/table-sort-icon.js 509 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 513 B 0 B
./.nuxt/dist/client/components/v-all-results-grid.js 7.46 kB -7 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.modern.js 4.96 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 387 B -1 B (0%)
./.nuxt/dist/client/components/v-audio-cell.modern.js 392 B 0 B
./.nuxt/dist/client/components/v-audio-details.js 2.54 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.01 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-track.js 5.2 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track.modern.js 5.15 kB 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.js 539 B +1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 542 B 0 B
./.nuxt/dist/client/components/v-bone.js 684 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 689 B 0 B
./.nuxt/dist/client/components/v-box-layout.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-box-layout.modern.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-content-link.js 1.11 kB 0 B
./.nuxt/dist/client/components/v-content-link.modern.js 1.09 kB +1 B (0%)
./.nuxt/dist/client/components/v-content-page.js 467 B 0 B
./.nuxt/dist/client/components/v-content-page.modern.js 470 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 779 B +5 B (+1%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 780 B -3 B (0%)
./.nuxt/dist/client/components/v-content-report-form.js 6.1 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.58 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.js 1.23 kB +2 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.23 kB -2 B (0%)
./.nuxt/dist/client/components/v-copy-button.js 3.99 kB 0 B
./.nuxt/dist/client/components/v-copy-button.modern.js 4 kB 0 B
./.nuxt/dist/client/components/v-copy-license.js 999 B -1 B (0%)
./.nuxt/dist/client/components/v-copy-license.modern.js 1 kB +1 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.88 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.86 kB 0 B
./.nuxt/dist/client/components/v-dmca-notice.js 748 B 0 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js 752 B -1 B (0%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB +1 B (0%)
./.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./.nuxt/dist/client/components/v-error-section.modern.js 375 B +1 B (0%)
./.nuxt/dist/client/components/v-external-search-form.js 1.91 kB -1 B (0%)
./.nuxt/dist/client/components/v-external-search-form.modern.js 1.9 kB +1 B (0%)
./.nuxt/dist/client/components/v-external-source-list.js 898 B 0 B
./.nuxt/dist/client/components/v-external-source-list.modern.js 902 B +1 B (0%)
./.nuxt/dist/client/components/v-full-layout.js 1.51 kB +1 B (0%)
./.nuxt/dist/client/components/v-full-layout.modern.js 1.51 kB -4 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB -3 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-home-gallery.js 4.79 kB +1 B (0%)
./.nuxt/dist/client/components/v-home-gallery.modern.js 4.78 kB +2 B (0%)
./.nuxt/dist/client/components/v-homepage-content.js 1.72 kB 0 B
./.nuxt/dist/client/components/v-homepage-content.modern.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-image-carousel.js 4.73 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-carousel.modern.js 4.7 kB +3 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-cell.js 1.45 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-cell.modern.js 1.45 kB 0 B
./.nuxt/dist/client/components/v-image-details.js 2.15 kB -2 B (0%)
./.nuxt/dist/client/components/v-image-details.modern.js 1.42 kB -2 B (0%)
./.nuxt/dist/client/components/v-image-grid.js 4.85 kB 0 B
./.nuxt/dist/client/components/v-image-grid.modern.js 2.39 kB +2 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.js 521 B -1 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 525 B 0 B
./.nuxt/dist/client/components/v-load-more.js 3.16 kB 0 B
./.nuxt/dist/client/components/v-load-more.modern.js 683 B 0 B
./.nuxt/dist/client/components/v-media-license.js 817 B -1 B (0%)
./.nuxt/dist/client/components/v-media-license.modern.js 828 B 0 B
./.nuxt/dist/client/components/v-media-reuse.js 1.62 kB -1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.62 kB +2 B (0%)
./.nuxt/dist/client/components/v-media-tag.js 429 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 433 B -1 B (0%)
./.nuxt/dist/client/components/v-modal.js 991 B 0 B
./.nuxt/dist/client/components/v-modal.modern.js 981 B 0 B
./.nuxt/dist/client/components/v-no-results.js 751 B 0 B
./.nuxt/dist/client/components/v-no-results.modern.js 750 B 0 B
./.nuxt/dist/client/components/v-radio.js 1.5 kB +1 B (0%)
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB -3 B (0%)
./.nuxt/dist/client/components/v-related-audio.js 1.25 kB +2 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.25 kB +2 B (0%)
./.nuxt/dist/client/components/v-related-images.js 1.05 kB +3 B (0%)
./.nuxt/dist/client/components/v-related-images.modern.js 2.95 kB +3 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 965 B 0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 966 B -1 B (0%)
./.nuxt/dist/client/components/v-row-layout.js 1.7 kB -1 B (0%)
./.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB -1 B (0%)
./.nuxt/dist/client/components/v-scroll-button.js 813 B 0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 818 B 0 B
./.nuxt/dist/client/components/v-search-grid.js 5.74 kB +2 B (0%)
./.nuxt/dist/client/components/v-search-grid.modern.js 5.66 kB +1 B (0%)
./.nuxt/dist/client/components/v-search-results-title.js 595 B +1 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 598 B -1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.js 796 B +1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.modern.js 768 B +1 B (0%)
./.nuxt/dist/client/components/v-server-timeout.js 299 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.37 kB 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 894 B +1 B (0%)
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB -2 B (0%)
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB +3 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/about.js 1.49 kB 0 B
./.nuxt/dist/client/pages/about.modern.js 1.49 kB -1 B (0%)
./.nuxt/dist/client/pages/external-sources.js 1.51 kB 0 B
./.nuxt/dist/client/pages/external-sources.modern.js 1.51 kB 0 B
./.nuxt/dist/client/pages/feedback.js 1.29 kB 0 B
./.nuxt/dist/client/pages/feedback.modern.js 1.29 kB 0 B
./.nuxt/dist/client/pages/index.js 6.85 kB +5 B (0%)
./.nuxt/dist/client/pages/index.modern.js 6.77 kB +1 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.23 kB +1 B (0%)
./.nuxt/dist/client/pages/preferences.modern.js 1.22 kB +1 B (0%)
./.nuxt/dist/client/pages/privacy.js 963 B -1 B (0%)
./.nuxt/dist/client/pages/privacy.modern.js 966 B 0 B
./.nuxt/dist/client/pages/search-help.js 1.56 kB -1 B (0%)
./.nuxt/dist/client/pages/search-help.modern.js 1.53 kB -1 B (0%)
./.nuxt/dist/client/pages/search/audio.js 6.07 kB 0 B
./.nuxt/dist/client/pages/search/audio.modern.js 3.58 kB -2 B (0%)
./.nuxt/dist/client/pages/search/image.js 563 B 0 B
./.nuxt/dist/client/pages/search/image.modern.js 2.63 kB 0 B
./.nuxt/dist/client/pages/search/index.js 508 B 0 B
./.nuxt/dist/client/pages/search/index.modern.js 515 B 0 B
./.nuxt/dist/client/pages/search/model-3d.js 242 B 0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./.nuxt/dist/client/pages/search/video.js 240 B 0 B
./.nuxt/dist/client/pages/search/video.modern.js 244 B 0 B
./.nuxt/dist/client/pages/sources.js 1.52 kB 0 B
./.nuxt/dist/client/pages/sources.modern.js 1.52 kB 0 B
./.nuxt/dist/client/runtime.js 2.74 kB 0 B
./.nuxt/dist/client/runtime.modern.js 2.74 kB 0 B
./.nuxt/dist/client/vendors/app.js 63.8 kB 0 B
./.nuxt/dist/client/vendors/app.modern.js 63 kB +1 B (0%)

compressed-size-action

@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature ♿️ aspect: a11y Concerns related to the project's accessibility and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 14, 2023
@obulat obulat force-pushed the add/skip_to_content_on_single_results branch from f426b10 to 49e3682 Compare February 15, 2023 14:18
zackkrida
zackkrida suggested changes Feb 15, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly. The one accessibility issue I'm noticing is that we have two nested main tags in the page:

image

@obulat obulat force-pushed the add/skip_to_content_on_single_results branch from 49e3682 to 246fefd Compare February 16, 2023 05:59
@obulat obulat force-pushed the add/skip_to_content_on_single_results branch from 246fefd to 3b0de05 Compare February 16, 2023 08:24
zackkrida
zackkrida approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ✅

dhruvkb
dhruvkb approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obulat obulat merged commit 38fcc6a into main Feb 16, 2023
@obulat obulat deleted the add/skip_to_content_on_single_results branch February 16, 2023 18:54
github-actions bot pushed a commit that referenced this pull request Feb 16, 2023
@openverse-bot
Clean preview for PR #2178
208cbc0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@zackkrida zackkrida zackkrida approved these changes

Assignees
No one assigned
Labels
♿️ aspect: a11y Concerns related to the project's accessibility ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obulat @zackkrida @dhruvkb @openverse-bot