Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove the unused old header code #2162

Merged
merged 15 commits into from
Feb 15, 2023
Merged

Remove the unused old header code #2162

merged 15 commits into from
Feb 15, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Feb 9, 2023 •
edited
Loading

Fixes

Fixes #2163 by @obulat

Description

In this PR, I:

  • removed old components and layouts
  • removed conditional formatting and properties in components, pages and layouts
  • removed no-longer necessary steps setting cookie sameSite to None.
  • removed old tests and navigation utilitis
  • comments that mention old_header or new_header.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner February 9, 2023 08:37
@obulat obulat requested review from zackkrida and dhruvkb February 9, 2023 08:37
@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited
Loading

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2162
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2162/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited
Loading

Size Change: -30.5 kB (-3%)

Total Size: 871 kB

Filename Size Change
./.nuxt/dist/client/213.js 0 B -272 B (removed) 🏆
./.nuxt/dist/client/213.modern.js 0 B -276 B (removed) 🏆
./.nuxt/dist/client/214.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 137 kB -12.2 kB (-8%) ✅
./.nuxt/dist/client/app.modern.js 111 kB -10.4 kB (-9%) ✅
./.nuxt/dist/client/commons/app.js 87.7 kB -88 B (0%)
./.nuxt/dist/client/commons/app.modern.js 78.1 kB -91 B (0%)
./.nuxt/dist/client/components/v-audio-track.js 5.2 kB -77 B (-1%)
./.nuxt/dist/client/components/v-audio-track.modern.js 5.15 kB -73 B (-1%)
./.nuxt/dist/client/components/v-full-layout.js 1.51 kB -78 B (-5%) ✅
./.nuxt/dist/client/components/v-full-layout.modern.js 1.51 kB -75 B (-5%) ✅
./.nuxt/dist/client/components/v-home-gallery.js 4.79 kB -16 B (0%)
./.nuxt/dist/client/components/v-image-carousel.js 4.73 kB -35 B (-1%)
./.nuxt/dist/client/components/v-image-carousel.modern.js 4.7 kB -27 B (-1%)
./.nuxt/dist/client/components/v-old-homepage-content.js 0 B -1.88 kB (removed) 🏆
./.nuxt/dist/client/components/v-old-homepage-content.modern.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/components/v-sources-table.js 16 kB -576 B (-3%)
./.nuxt/dist/client/components/v-sources-table.modern.js 16 kB -572 B (-3%)
./.nuxt/dist/client/pages/about.js 1.49 kB -32 B (-2%)
./.nuxt/dist/client/pages/about.modern.js 1.5 kB -32 B (-2%)
./.nuxt/dist/client/pages/audio/_id/index.js 7.96 kB -48 B (-1%)
./.nuxt/dist/client/pages/audio/_id/index.modern.js 4.79 kB -56 B (-1%)
./.nuxt/dist/client/pages/external-sources.js 1.51 kB -31 B (-2%)
./.nuxt/dist/client/pages/external-sources.modern.js 1.51 kB -29 B (-2%)
./.nuxt/dist/client/pages/feedback.js 1.29 kB -32 B (-2%)
./.nuxt/dist/client/pages/feedback.modern.js 1.29 kB -33 B (-2%)
./.nuxt/dist/client/pages/image/_id/index.js 9.22 kB -93 B (-1%)
./.nuxt/dist/client/pages/image/_id/index.modern.js 7.32 kB -87 B (-1%)
./.nuxt/dist/client/pages/index.js 6.84 kB -1.8 kB (-21%) 🎉
./.nuxt/dist/client/pages/index.modern.js 6.76 kB -1.75 kB (-21%) 🎉
./.nuxt/dist/client/pages/privacy.js 962 B -32 B (-3%)
./.nuxt/dist/client/pages/privacy.modern.js 966 B -29 B (-3%)
./.nuxt/dist/client/pages/search-help.js 1.59 kB -30 B (-2%)
./.nuxt/dist/client/pages/search-help.modern.js 1.59 kB -32 B (-2%)
./.nuxt/dist/client/pages/search.js 5.11 kB -68 B (-1%)
./.nuxt/dist/client/pages/search.modern.js 2.6 kB -66 B (-2%)
./.nuxt/dist/client/pages/search/audio.js 6.16 kB +31 B (+1%)
./.nuxt/dist/client/pages/search/audio.modern.js 3.66 kB +26 B (+1%)
./.nuxt/dist/client/pages/search/image.js 624 B +28 B (+5%) 🔍
./.nuxt/dist/client/pages/search/image.modern.js 2.75 kB +26 B (+1%)
./.nuxt/dist/client/pages/search/index.js 508 B +27 B (+6%) 🔍
./.nuxt/dist/client/pages/search/index.modern.js 513 B +26 B (+5%) 🔍
./.nuxt/dist/client/pages/sources.js 1.52 kB -33 B (-2%)
./.nuxt/dist/client/pages/sources.modern.js 1.52 kB -33 B (-2%)
./.nuxt/dist/client/runtime.js 2.55 kB -75 B (-3%)
./.nuxt/dist/client/runtime.modern.js 2.56 kB -78 B (-3%)
./.nuxt/dist/client/vendors/app.js 63.8 kB +46 B (0%)
./.nuxt/dist/client/vendors/app.modern.js 62.9 kB -113 B (0%)
./.nuxt/dist/client/198.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/198.modern.js 278 B +278 B (new file) 🆕
./.nuxt/dist/client/199.js 1.85 kB +1.85 kB (new file) 🆕
./.nuxt/dist/client/components/v-modal.js 990 B +990 B (new file) 🆕
./.nuxt/dist/client/components/v-modal.modern.js 981 B +981 B (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/components/loading-icon.js 746 B -2 B (0%)
./.nuxt/dist/client/components/loading-icon.modern.js 752 B +3 B (0%)
./.nuxt/dist/client/components/table-sort-icon.js 509 B +1 B (0%)
./.nuxt/dist/client/components/table-sort-icon.modern.js 513 B 0 B
./.nuxt/dist/client/components/v-all-results-grid.js 7.54 kB -3 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.modern.js 5.06 kB +7 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 388 B +4 B (+1%)
./.nuxt/dist/client/components/v-audio-cell.modern.js 393 B 0 B
./.nuxt/dist/client/components/v-audio-details.js 2.54 kB +4 B (0%)
./.nuxt/dist/client/components/v-audio-details.modern.js 1.78 kB -3 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB -1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 539 B +1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 542 B -1 B (0%)
./.nuxt/dist/client/components/v-bone.js 684 B -1 B (0%)
./.nuxt/dist/client/components/v-bone.modern.js 690 B +1 B (0%)
./.nuxt/dist/client/components/v-box-layout.js 1.23 kB -1 B (0%)
./.nuxt/dist/client/components/v-box-layout.modern.js 1.23 kB -1 B (0%)
./.nuxt/dist/client/components/v-content-link.js 1.11 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-link.modern.js 1.09 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-page.js 467 B +1 B (0%)
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 778 B +4 B (+1%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 783 B +2 B (0%)
./.nuxt/dist/client/components/v-content-report-form.js 6.1 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.58 kB -4 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.js 1.23 kB +4 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.23 kB -2 B (0%)
./.nuxt/dist/client/components/v-copy-button.js 3.99 kB -1 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 4 kB +3 B (0%)
./.nuxt/dist/client/components/v-copy-license.js 998 B -2 B (0%)
./.nuxt/dist/client/components/v-copy-license.modern.js 998 B -3 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.87 kB -5 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.85 kB +1 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.js 748 B +4 B (+1%)
./.nuxt/dist/client/components/v-dmca-notice.modern.js 753 B +2 B (0%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB -6 B (0%)
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-error-section.js 372 B -1 B (0%)
./.nuxt/dist/client/components/v-error-section.modern.js 374 B -2 B (-1%)
./.nuxt/dist/client/components/v-external-search-form.js 2.07 kB +1 B (0%)
./.nuxt/dist/client/components/v-external-search-form.modern.js 2.05 kB +3 B (0%)
./.nuxt/dist/client/components/v-external-source-list.js 900 B -1 B (0%)
./.nuxt/dist/client/components/v-external-source-list.modern.js 903 B +4 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB -3 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-home-gallery.modern.js 4.78 kB +2 B (0%)
./.nuxt/dist/client/components/v-homepage-content.js 1.72 kB -3 B (0%)
./.nuxt/dist/client/components/v-homepage-content.modern.js 1.69 kB -2 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-cell.js 1.45 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-cell.modern.js 1.44 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-details.js 2.15 kB +5 B (0%)
./.nuxt/dist/client/components/v-image-details.modern.js 1.42 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-grid.js 4.93 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-grid.modern.js 2.47 kB -5 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.js 521 B 0 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 524 B -1 B (0%)
./.nuxt/dist/client/components/v-load-more.js 3.16 kB +2 B (0%)
./.nuxt/dist/client/components/v-load-more.modern.js 684 B 0 B
./.nuxt/dist/client/components/v-media-license.js 819 B 0 B
./.nuxt/dist/client/components/v-media-license.modern.js 828 B +1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.js 1.62 kB -1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.61 kB 0 B
./.nuxt/dist/client/components/v-media-tag.js 429 B +1 B (0%)
./.nuxt/dist/client/components/v-media-tag.modern.js 433 B -1 B (0%)
./.nuxt/dist/client/components/v-no-results.js 751 B -1 B (0%)
./.nuxt/dist/client/components/v-no-results.modern.js 751 B 0 B
./.nuxt/dist/client/components/v-radio.js 1.5 kB -7 B (0%)
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB +1 B (0%)
./.nuxt/dist/client/components/v-related-audio.js 1.25 kB -1 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.25 kB +4 B (0%)
./.nuxt/dist/client/components/v-related-images.js 1.05 kB -1 B (0%)
./.nuxt/dist/client/components/v-related-images.modern.js 3.03 kB -3 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 965 B 0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 967 B -1 B (0%)
./.nuxt/dist/client/components/v-row-layout.js 1.7 kB -1 B (0%)
./.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB -2 B (0%)
./.nuxt/dist/client/components/v-scroll-button.js 813 B 0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 818 B -1 B (0%)
./.nuxt/dist/client/components/v-search-grid.js 5.88 kB +5 B (0%)
./.nuxt/dist/client/components/v-search-grid.modern.js 5.8 kB -4 B (0%)
./.nuxt/dist/client/components/v-search-results-title.js 595 B -1 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 600 B +1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.js 795 B +4 B (+1%)
./.nuxt/dist/client/components/v-search-type-radio.modern.js 770 B +3 B (0%)
./.nuxt/dist/client/components/v-server-timeout.js 299 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.37 kB +2 B (0%)
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 895 B +1 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.js 887 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 892 B -4 B (0%)
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB +1 B (0%)
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB +1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/image/_id/report.js 3.6 kB +4 B (0%)
./.nuxt/dist/client/pages/image/_id/report.modern.js 4.2 kB -3 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.23 kB +4 B (0%)
./.nuxt/dist/client/pages/preferences.modern.js 1.22 kB -1 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 243 B 0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js 247 B +1 B (0%)
./.nuxt/dist/client/pages/search/search-page.types.js 266 B +1 B (0%)
./.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./.nuxt/dist/client/pages/search/video.js 240 B 0 B
./.nuxt/dist/client/pages/search/video.modern.js 244 B +1 B (0%)

compressed-size-action

@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 9, 2023
@WordPress WordPress deleted a comment from github-actions bot Feb 9, 2023
@zackkrida
Copy link
Member

CleanShot 2023-02-09 at 09 17 25 Amazing ❤️

@obulat obulat force-pushed the remove_old_header_code branch from 6f1cff6 to 61a2fa0 Compare February 11, 2023 07:29
dhruvkb
dhruvkb approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-02-11 at 1 04 17 PM

Nice! Also CI is passing which is a good sign.

@openverse-bot
Copy link
Contributor

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@zackkrida
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2.

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday. ↩

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

zackkrida
zackkrida approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. I made sure to test in several browsers and everything is behaving correctly.

@obulat obulat merged commit aa1367a into main Feb 15, 2023
@obulat obulat deleted the remove_old_header_code branch February 15, 2023 14:04
github-actions bot pushed a commit that referenced this pull request Feb 15, 2023
@openverse-bot
Clean preview for PR #2162
363b9f8
@obulat obulat mentioned this pull request Feb 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the old_header code
4 participants
@obulat @zackkrida @openverse-bot @dhruvkb