This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Minify homepage images #2158
Merged
Minify homepage images #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2158 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
zackkrida
added
🟩 priority: low
dhruvkb
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
This is great, would also love to see if adding a WEBP variant and using <picture> and <source> can further reduce the sizes when the format is supported.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR to minify the images on the homepage. Changes are lossless and any visual differences should be nonexistient/imperceptible.
Results in a average 66% decrease in image size for each homepage viewing. See the pottery view as an example:
Before: 1.8MB in images
After: 625kb in images
Passing visual regression tests should affirm the lack of meaningful visual change.