This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Remove ring offset to reduce ring thickness #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2149 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🟩 priority: low
|
Size Change: -4.97 kB (-1%) Total Size: 894 kB
ℹ️ View Unchanged
|
|
This component would look great if it changes to Link's Figma component. The style is almost the same, and it adds consistency to the upcoming style revisit goal.
I hope it stays within the same purpose of this PR. |
|
@panchovm we could make it look like a Link but since it is a functionally a Button, some of the interactions would be different. For example, if you hover over a link, it might change text color or show an underline but the same interactions on a button would look very out of place. |
|
Let's keep it as VButton then. I am currently working on a design proposal for improving the VButton style across the site and Figma documentation. So leveraging this and other similar cases in the idea I am handling. Thanks @dhruvkb. |
|
In that case, I'll undraft this so that can can patch the bug and we will refine the UI with the rest of the UI refinement project that will include the refresh of the button designs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2129 by @dhruvkb
Description
This PR removes the ring offset from the 'Clear filters' button because that causes the ring to appear thicker. Now the thickness of the focus ring is consistent with the rest of the app.
Testing Instructions
Screenshots
Screen.Recording.2023-02-07.at.10.48.36.AM.mov
^ The first occurrence is the move hover and the second is the keyboard focus
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin