This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions but otherwise LGTM 😁 🚀
…into cc_migration_bar
Resolved conflicts with |
zackkrida
approved these changes
Sep 16, 2021
@dhruvkb LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
💻 aspect: code
Concerns the software code in the repository
🌟 goal: addition
Addition of new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #194 by @zackkrida
Description
This PR creates the
NoticeBar
component for showing notices and uses it to show theMigrationNotice
component on the top of the page.Technical details
The notice is shown on first render and disappears after you navigate to a different link. This means that the code for this is split across a plugin (
plugins/migration-notice.js
) and a middleware (middleware/middleware.js
).Screenshots
URL:
http://localhost:8443/?referrer=creativecommons.org
URL:
http://localhost:8443/search/?q=cat&referrer=creativecommons.org
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin