Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Show a CC Search → Openverse notice #212

Merged
merged 12 commits into from
Sep 16, 2021
Merged

Show a CC Search → Openverse notice #212

merged 12 commits into from
Sep 16, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 14, 2021

Fixes

Fixes #194 by @zackkrida

Description

This PR creates the NoticeBar component for showing notices and uses it to show the MigrationNotice component on the top of the page.

Technical details

The notice is shown on first render and disappears after you navigate to a different link. This means that the code for this is split across a plugin (plugins/migration-notice.js) and a middleware (middleware/middleware.js).

Screenshots

URL: http://localhost:8443/?referrer=creativecommons.org

image


URL: http://localhost:8443/search/?q=cat&referrer=creativecommons.org

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Sep 14, 2021
@dhruvkb dhruvkb marked this pull request as ready for review September 14, 2021 15:43
@dhruvkb dhruvkb requested a review from a team as a code owner September 14, 2021 15:43
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions but otherwise LGTM 😁 🚀

src/components/NoticeBar/NoticeBar.vue Outdated Show resolved Hide resolved
src/components/MigrationNotice.vue Show resolved Hide resolved
src/plugins/migration-notice.js Outdated Show resolved Hide resolved
@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 16, 2021

Resolved conflicts with main

@zackkrida
Copy link
Member

@dhruvkb LGTM!

@dhruvkb dhruvkb merged commit 193ce65 into main Sep 16, 2021
@dhruvkb dhruvkb deleted the cc_migration_bar branch September 16, 2021 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add top bar for former CC Search users
3 participants