This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Set layout height to 100dvh with fallback to 100vh #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟧 priority: high
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2115 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: -10.4 kB (-1%) Total Size: 887 kB
ℹ️ View Unchanged
|
|
The problem with the modal being cut off is fixed, which is great. But this PR does not fix the issue of the background getting cut off.
|
zackkrida
reviewed
Feb 1, 2023
|
@obulat not related to the changes in this PR, I noticed that desktop safari needs the homepage to explicitly have
I think it's some kind of bug related to min-height, flex containers, and sticky flex children 😢 I will test this on a browser that doesn't support |
obulat
force-pushed
the
fix/default_height
branch
from
1d1f6dc to
f51a5fc
Compare
obulat
changed the title
zackkrida
reviewed
Feb 2, 2023
zackkrida
approved these changes
Feb 2, 2023
Co-authored-by: Zack Krida <zackkrida@pm.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2110 by @obulat
Description
This PR fixes the bug where the bottom of the screen is cut-off and hidden behind the address bar on mobiles by using
dvhunits for screen height.Currently, the support for them is below 80%, so as a fallback, we set the height to 100 vh but also add a bottom padding to the modals to make sure that clickable elements are not hidden.
Testing Instructions
Run the app and test it on a mobile. You should see the WordPress logo in the footer. When you input something in the hompage searchbar, even the bottom part of the screen should remain yellow. When you open modal (content switcher on homepage), none of it should be hidden.
I don't have a phone to test the fallback, it would be nice if someone could test it on a real device.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin