Update `Footer` spacings #2091

dhruvkb · 2023-01-10T06:13:08Z

Fixes

Fixes #2072 by @panchovm

Description

This PR updates the spacing in the footer to keep in sync with the updated mockups.

Testing Instructions

Check out the PR and run the Storybook.
Explore the VFooter story at various breakpoints.

Checklist

My pull request has a descriptive title (not a vague title like
Update index.md).
My pull request targets the default branch of the repository (main) or
a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-01-10T06:13:25Z

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2091
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2091/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

github-actions · 2023-01-10T06:19:41Z

Size Change: +40 B (0%)

Total Size: 896 kB

Filename	Size	Change
`./.nuxt/dist/client/app.js`	148 kB	+19 B (0%)
`./.nuxt/dist/client/app.modern.js`	123 kB	+21 B (0%)

ℹ️ View Unchanged

Filename	Size
`./.nuxt/dist/client/236.js`	272 B
`./.nuxt/dist/client/236.modern.js`	277 B
`./.nuxt/dist/client/237.js`	1.85 kB
`./.nuxt/dist/client/commons/app.js`	86.7 kB
`./.nuxt/dist/client/commons/app.modern.js`	77.4 kB
`./.nuxt/dist/client/components/loading-icon.js`	747 B
`./.nuxt/dist/client/components/loading-icon.modern.js`	748 B
`./.nuxt/dist/client/components/table-sort-icon.js`	508 B
`./.nuxt/dist/client/components/table-sort-icon.modern.js`	513 B
`./.nuxt/dist/client/components/v-all-results-grid.js`	7.49 kB
`./.nuxt/dist/client/components/v-all-results-grid.modern.js`	5.01 kB
`./.nuxt/dist/client/components/v-audio-cell.js`	357 B
`./.nuxt/dist/client/components/v-audio-cell.modern.js`	361 B
`./.nuxt/dist/client/components/v-audio-details.js`	2.53 kB
`./.nuxt/dist/client/components/v-audio-details.modern.js`	1.78 kB
`./.nuxt/dist/client/components/v-audio-track-skeleton.js`	1.01 kB
`./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	1.02 kB
`./.nuxt/dist/client/components/v-audio-track.js`	5.19 kB
`./.nuxt/dist/client/components/v-audio-track.modern.js`	5.14 kB
`./.nuxt/dist/client/components/v-back-to-search-results-link.js`	537 B
`./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	543 B
`./.nuxt/dist/client/components/v-bone.js`	684 B
`./.nuxt/dist/client/components/v-bone.modern.js`	687 B
`./.nuxt/dist/client/components/v-box-layout.js`	1.21 kB
`./.nuxt/dist/client/components/v-box-layout.modern.js`	1.2 kB
`./.nuxt/dist/client/components/v-content-link.js`	1.11 kB
`./.nuxt/dist/client/components/v-content-link.modern.js`	1.09 kB
`./.nuxt/dist/client/components/v-content-page.js`	467 B
`./.nuxt/dist/client/components/v-content-page.modern.js`	471 B
`./.nuxt/dist/client/components/v-content-report-button.js`	778 B
`./.nuxt/dist/client/components/v-content-report-button.modern.js`	779 B
`./.nuxt/dist/client/components/v-content-report-form.js`	6.08 kB
`./.nuxt/dist/client/components/v-content-report-form.modern.js`	3.57 kB
`./.nuxt/dist/client/components/v-content-report-popover.js`	1.22 kB
`./.nuxt/dist/client/components/v-content-report-popover.modern.js`	4.22 kB
`./.nuxt/dist/client/components/v-copy-button.js`	3.99 kB
`./.nuxt/dist/client/components/v-copy-button.modern.js`	3.99 kB
`./.nuxt/dist/client/components/v-copy-license.js`	1 kB
`./.nuxt/dist/client/components/v-copy-license.modern.js`	1 kB
`./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js`	9.87 kB
`./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js`	9.84 kB
`./.nuxt/dist/client/components/v-dmca-notice.js`	749 B
`./.nuxt/dist/client/components/v-dmca-notice.modern.js`	751 B
`./.nuxt/dist/client/components/v-error-image.js`	1.7 kB
`./.nuxt/dist/client/components/v-error-image.modern.js`	1.68 kB
`./.nuxt/dist/client/components/v-error-section.js`	372 B
`./.nuxt/dist/client/components/v-error-section.modern.js`	375 B
`./.nuxt/dist/client/components/v-external-search-form.js`	3.09 kB
`./.nuxt/dist/client/components/v-external-search-form.modern.js`	3.06 kB
`./.nuxt/dist/client/components/v-external-source-list.js`	2.55 kB
`./.nuxt/dist/client/components/v-external-source-list.modern.js`	2.52 kB
`./.nuxt/dist/client/components/v-full-layout.js`	1.59 kB
`./.nuxt/dist/client/components/v-full-layout.modern.js`	1.59 kB
`./.nuxt/dist/client/components/v-grid-skeleton.js`	1.61 kB
`./.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.62 kB
`./.nuxt/dist/client/components/v-home-gallery.js`	4.8 kB
`./.nuxt/dist/client/components/v-home-gallery.modern.js`	4.79 kB
`./.nuxt/dist/client/components/v-homepage-content.js`	820 B
`./.nuxt/dist/client/components/v-homepage-content.modern.js`	823 B
`./.nuxt/dist/client/components/v-image-carousel.js`	4.76 kB
`./.nuxt/dist/client/components/v-image-carousel.modern.js`	4.74 kB
`./.nuxt/dist/client/components/v-image-cell-square.js`	993 B
`./.nuxt/dist/client/components/v-image-cell-square.modern.js`	997 B
`./.nuxt/dist/client/components/v-image-cell.js`	1.43 kB
`./.nuxt/dist/client/components/v-image-cell.modern.js`	1.42 kB
`./.nuxt/dist/client/components/v-image-details.js`	2.14 kB
`./.nuxt/dist/client/components/v-image-details.modern.js`	1.42 kB
`./.nuxt/dist/client/components/v-image-grid.js`	4.88 kB
`./.nuxt/dist/client/components/v-image-grid.modern.js`	2.42 kB
`./.nuxt/dist/client/components/v-license-tab-panel.js`	521 B
`./.nuxt/dist/client/components/v-license-tab-panel.modern.js`	525 B
`./.nuxt/dist/client/components/v-load-more.js`	3.16 kB
`./.nuxt/dist/client/components/v-load-more.modern.js`	683 B
`./.nuxt/dist/client/components/v-media-license.js`	819 B
`./.nuxt/dist/client/components/v-media-license.modern.js`	828 B
`./.nuxt/dist/client/components/v-media-reuse.js`	1.62 kB
`./.nuxt/dist/client/components/v-media-reuse.modern.js`	1.61 kB
`./.nuxt/dist/client/components/v-media-tag.js`	428 B
`./.nuxt/dist/client/components/v-media-tag.modern.js`	433 B
`./.nuxt/dist/client/components/v-no-results.js`	2.75 kB
`./.nuxt/dist/client/components/v-no-results.modern.js`	2.72 kB
`./.nuxt/dist/client/components/v-old-homepage-content.js`	1.88 kB
`./.nuxt/dist/client/components/v-old-homepage-content.modern.js`	1.85 kB
`./.nuxt/dist/client/components/v-radio.js`	1.51 kB
`./.nuxt/dist/client/components/v-radio.modern.js`	1.47 kB
`./.nuxt/dist/client/components/v-related-audio.js`	1.25 kB
`./.nuxt/dist/client/components/v-related-audio.modern.js`	1.25 kB
`./.nuxt/dist/client/components/v-related-images.js`	1.05 kB
`./.nuxt/dist/client/components/v-related-images.modern.js`	2.98 kB
`./.nuxt/dist/client/components/v-report-desc-form.js`	965 B
`./.nuxt/dist/client/components/v-report-desc-form.modern.js`	969 B
`./.nuxt/dist/client/components/v-row-layout.js`	1.7 kB
`./.nuxt/dist/client/components/v-row-layout.modern.js`	1.71 kB
`./.nuxt/dist/client/components/v-scroll-button.js`	813 B
`./.nuxt/dist/client/components/v-scroll-button.modern.js`	819 B
`./.nuxt/dist/client/components/v-search-grid.js`	5.43 kB
`./.nuxt/dist/client/components/v-search-grid.modern.js`	5.38 kB
`./.nuxt/dist/client/components/v-search-results-title.js`	656 B
`./.nuxt/dist/client/components/v-search-results-title.modern.js`	655 B
`./.nuxt/dist/client/components/v-search-type-radio.js`	792 B
`./.nuxt/dist/client/components/v-search-type-radio.modern.js`	768 B
`./.nuxt/dist/client/components/v-server-timeout.js`	299 B
`./.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B
`./.nuxt/dist/client/components/v-sketch-fab-viewer.js`	3.37 kB
`./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	895 B
`./.nuxt/dist/client/components/v-skip-to-content-container.js`	888 B
`./.nuxt/dist/client/components/v-skip-to-content-container.modern.js`	894 B
`./.nuxt/dist/client/components/v-snackbar.js`	1.18 kB
`./.nuxt/dist/client/components/v-snackbar.modern.js`	1.19 kB
`./.nuxt/dist/client/components/v-sources-table.js`	16.5 kB
`./.nuxt/dist/client/components/v-sources-table.modern.js`	16.6 kB
`./.nuxt/dist/client/components/v-warning-suppressor.js`	299 B
`./.nuxt/dist/client/components/v-warning-suppressor.modern.js`	302 B
`./.nuxt/dist/client/pages/about.js`	1.51 kB
`./.nuxt/dist/client/pages/about.modern.js`	1.51 kB
`./.nuxt/dist/client/pages/audio/_id.js`	7.96 kB
`./.nuxt/dist/client/pages/audio/_id.modern.js`	4.79 kB
`./.nuxt/dist/client/pages/external-sources.js`	1.53 kB
`./.nuxt/dist/client/pages/external-sources.modern.js`	1.53 kB
`./.nuxt/dist/client/pages/feedback.js`	1.31 kB
`./.nuxt/dist/client/pages/feedback.modern.js`	1.31 kB
`./.nuxt/dist/client/pages/image/_id.js`	9.25 kB
`./.nuxt/dist/client/pages/image/_id.modern.js`	7.33 kB
`./.nuxt/dist/client/pages/index.js`	7.97 kB
`./.nuxt/dist/client/pages/index.modern.js`	7.86 kB
`./.nuxt/dist/client/pages/preferences.js`	1.22 kB
`./.nuxt/dist/client/pages/preferences.modern.js`	1.2 kB
`./.nuxt/dist/client/pages/privacy.js`	983 B
`./.nuxt/dist/client/pages/privacy.modern.js`	984 B
`./.nuxt/dist/client/pages/search-help.js`	1.61 kB
`./.nuxt/dist/client/pages/search-help.modern.js`	1.61 kB
`./.nuxt/dist/client/pages/search.js`	5.09 kB
`./.nuxt/dist/client/pages/search.modern.js`	2.6 kB
`./.nuxt/dist/client/pages/search/audio.js`	6.14 kB
`./.nuxt/dist/client/pages/search/audio.modern.js`	3.65 kB
`./.nuxt/dist/client/pages/search/image.js`	661 B
`./.nuxt/dist/client/pages/search/image.modern.js`	2.73 kB
`./.nuxt/dist/client/pages/search/index.js`	542 B
`./.nuxt/dist/client/pages/search/index.modern.js`	548 B
`./.nuxt/dist/client/pages/search/model-3d.js`	243 B
`./.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B
`./.nuxt/dist/client/pages/search/search-page.types.js`	266 B
`./.nuxt/dist/client/pages/search/search-page.types.modern.js`	271 B
`./.nuxt/dist/client/pages/search/video.js`	240 B
`./.nuxt/dist/client/pages/search/video.modern.js`	244 B
`./.nuxt/dist/client/pages/sources.js`	1.55 kB
`./.nuxt/dist/client/pages/sources.modern.js`	1.54 kB
`./.nuxt/dist/client/runtime.js`	2.73 kB
`./.nuxt/dist/client/runtime.modern.js`	2.73 kB
`./.nuxt/dist/client/vendors/app.js`	63.7 kB
`./.nuxt/dist/client/vendors/app.modern.js`	63.1 kB

_{compressed-size-action}

zackkrida

The snapshots look nice; LGTM.

openverse-bot · 2023-01-17T00:00:06Z

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@obulat
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was updated 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)².

@dhruvkb, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Specifically, Saturday and Sunday. ↩
For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

obulat

LGTM!

Update Footer spacings

997bb3e

openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Jan 10, 2023

dhruvkb added 2 commits January 10, 2023 15:04

Update snapshots

f4847f8

Update snapshots

e19133e

dhruvkb marked this pull request as ready for review January 10, 2023 15:39

dhruvkb requested a review from a team as a code owner January 10, 2023 15:39

dhruvkb requested review from zackkrida and obulat January 10, 2023 15:39

zackkrida approved these changes Jan 10, 2023

View reviewed changes

obulat approved these changes Jan 17, 2023

View reviewed changes

dhruvkb merged commit 8df7307 into main Jan 17, 2023

dhruvkb deleted the footer_spacing branch January 17, 2023 14:03

github-actions bot pushed a commit that referenced this pull request Jan 17, 2023

Clean preview for PR #2091

002a6be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `Footer` spacings #2091

Update `Footer` spacings #2091

dhruvkb commented Jan 10, 2023

github-actions bot commented Jan 10, 2023 •

edited

Loading

github-actions bot commented Jan 10, 2023 •

edited

Loading

zackkrida left a comment

openverse-bot commented Jan 17, 2023

obulat left a comment

Update Footer spacings #2091

Update Footer spacings #2091

Conversation

dhruvkb commented Jan 10, 2023

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

github-actions bot commented Jan 10, 2023 • edited Loading

github-actions bot commented Jan 10, 2023 • edited Loading

zackkrida left a comment

Choose a reason for hiding this comment

openverse-bot commented Jan 17, 2023

Footnotes

obulat left a comment

Choose a reason for hiding this comment

Update `Footer` spacings #2091

Update `Footer` spacings #2091

github-actions bot commented Jan 10, 2023 •

edited

Loading

github-actions bot commented Jan 10, 2023 •

edited

Loading