This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Image reporting view #2090
Merged
Image reporting view #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2090 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: +8.05 kB (+1%) Total Size: 907 kB
ℹ️ View Unchanged
|
6 tasks
obulat
reviewed
Jan 10, 2023
| @@ -5,12 +5,14 @@ | |||
| v-bind="$attrs" | |||
There was a problem hiding this comment.
Maybe rename this component to VBackLink?
There was a problem hiding this comment.
We can remove this change entirely now, right? The component is no longer used in the new report page.
obulat
reviewed
Jan 10, 2023
zackkrida
added
needs design
|
I designed this quick idea that taps into existing styles and your approach.
DescriptionThe page has the Footer content and the header version where switcher and filters are disabled. This version was discussed in a different ticket but is not fully defined yet. In the result area, the wrapper is
All text styles and buttons are existing components. The mockup lists them better. What do you think? If we go with this idea, I will polish minor mockup details for its implementation. Design fileFigma: Full page report |
|
Thanks, @panchovm! This looks great. I can implement these suggestions pretty quickly once you've made final tweaks. No objections on the overall design. |
|
Done. The file has been updated. Here are the mockups and a wireframe. Select View > Layout Grids to see the grid settings of all mockups. |
|
@panchovm and @obulat I think this PR is in a good place to merge. The only change that wasn't made, which could be in a subsequent PR, is to update the type sizes of headings and move the button to the left. I think those changes require a bit more work to add props and more configuration to the What do you think? |
zackkrida
added
🟥 priority: critical
fcoveram
approved these changes
Jan 18, 2023
sarayourfriend
suggested changes
Jan 19, 2023
| @@ -5,12 +5,14 @@ | |||
| v-bind="$attrs" | |||
There was a problem hiding this comment.
We can remove this change entirely now, right? The component is no longer used in the new report page.
src/pages/image/_id/report.vue
Outdated
Comment on lines
22
to
25
| variant="secondary-bordered" | ||
| :href="`/image/${image.id}`" | ||
| size="disabled" | ||
| class="p-2 text-sr" |
There was a problem hiding this comment.
Suggested change
| variant="secondary-bordered" | |
| :href="`/image/${image.id}`" | |
| size="disabled" | |
| class="p-2 text-sr" | |
| as="VLink" | |
| variant="secondary-bordered" | |
| :href="`/image/${image.id}`" | |
| size="disabled" | |
| class="p-2 text-sr text-black" |
The additional class is required to prevent the button text from switching to the pink used for links (not sure if this is intentional or a bug in the component).
zackkrida
removed
the
needs design
sarayourfriend
approved these changes
Jan 19, 2023
7 tasks
obulat
reviewed
Jan 20, 2023
obulat
approved these changes
Jan 20, 2023
Co-authored-by: Olga Bulat <obulat@gmail.com>
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/3965536056 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof-of-concept to create a reporting view for each image. This would allow Openverse integrations to have a simple reporting URL for each image.
Todo