Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove unused code #208

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Remove unused code #208

merged 2 commits into from
Sep 13, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 13, 2021

Description

We have set up self-hosting of fonts in #31. However, they are still also loaded from unpkg. This PR removes unpkg loading of the fonts.
Another piece of code removed by this PR is the left-over code from vue-infinite-loading plugin that was removed with infinite loading.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner September 13, 2021 10:46
@obulat obulat requested review from krysal and dhruvkb September 13, 2021 10:46
@obulat obulat added bug Something isn't working 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Sep 13, 2021
@zackkrida zackkrida merged commit c90e8ab into main Sep 13, 2021
@zackkrida zackkrida deleted the remove_unused_code branch September 13, 2021 19:54
@zackkrida zackkrida mentioned this pull request Sep 15, 2021
@krysal krysal mentioned this pull request Sep 15, 2021
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants