This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
External sources on no results page #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2077 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -11.1 kB (-1%) Total Size: 899 kB
ℹ️ View Unchanged
|
dhruvkb
reviewed
Jan 2, 2023
fcoveram
suggested changes
Jan 4, 2023
There was a problem hiding this comment.
The change looks great, and since there is no mockup, I suggest applying two changes:
- Text style: Apply the "Label bold" style as defined in the Design Library.
- Spacing: Set a
8pxgap between label and icon.
Sorry for replying late as I was reviewing the buttons created in the Design Library and in storybook to select the correct one. However, there are multiple inconsistencies between both sources that do not block this PR. Applying the changes described above is sufficient.
In parallel, I started exploring a layout improvement for this and Timeout pages that will share in a separate design ticket.
obulat
commented
Jan 5, 2023
obulat
force-pushed
the
external_sources_on_no_results_page
branch
from
37c2d8c to
7d127fa
Compare
dhruvkb
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
The changes look good to me!
I have some issues with the look of full-width buttons at the tablet breakpoint but that's a design issue and not something to block the PR over. @panchovm maybe more than one column or just the individual buttons as seen on the desktop would be better.
7 tasks
|
Thanks for the suggestion @dhruvkb I am currently working on a proposal for updating this and Timeout pages' layouts. For this PR scope, the buttons look correct. I plan to share the layout proposal soon. |
zackkrida
approved these changes
Jan 12, 2023
fcoveram
previously requested changes
Jan 12, 2023
There was a problem hiding this comment.
I suggested two spacing tweaks in the layout that have nothing to do with the button's style.
For @zackkrida's point. Yes, the button style is something we need to tackle in the future to address the spacing consistency across the site.
obulat
force-pushed
the
external_sources_on_no_results_page
branch
from
7d127fa to
7c0e2f7
Compare
obulat
dismissed
fcoveram’s stale review
The requested changes were implemented
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1999 by @obulat
Description
This PR refactors the No results page to use rows/column of buttons.
@panchovm, there are no updated mockups for this in Figma, so I'll need your input on paddings and sizes.
Testing Instructions
Run the app, and try searching for something that doesn't have any results, something like "lskdjflskdjflsk". This should open a "No results" page. Here, on desktop, the external sources should be in a row of buttons, and on mobile, in a column.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin