This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Ping staging deployer in Slack notification #2053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2053 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
label
Dec 15, 2022
krysal
added
🟩 priority: low
Low priority and doesn't need to be rushed
🤖 aspect: dx
Concerns developers' experience with the codebase
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
and removed
🚦 status: awaiting triage
Has not been triaged & therefore, not ready for work
labels
Dec 15, 2022
zackkrida
reviewed
Dec 15, 2022
obulat
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see how it works!
I think Zack's note needs to be added in the upstream implementation.
We'll see if this works by merging it right now 🤞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🤖 aspect: dx
Concerns developers' experience with the codebase
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟩 priority: low
Low priority and doesn't need to be rushed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #2052 by @krysal
Description
This PRs updates
.github/actions/staging-frontend-deploy/action.yml
with the output from terraform.Let's test on staging first to see if it works correctly, then once confirmed the same changes will be applied to the
.github/actions/production-frontend-deploy/action.yml
file.Testing Instructions
Merge and trigger a staging deployment to confirm.
Developer Certificate of Origin
Developer Certificate of Origin