This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Move getting localized search path to the search store #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2045 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
obulat
force-pushed
the
extract_locale_path
branch
from
e0f5b90 to
1b582a0
Compare
|
Size Change: -7.61 kB (-1%) Total Size: 864 kB
ℹ️ View Unchanged
|
zackkrida
reviewed
Dec 14, 2022
zackkrida
approved these changes
Dec 14, 2022
obulat
force-pushed
the
extract_locale_path
branch
from
1c24ca4 to
01afe7b
Compare
krysal
approved these changes
Dec 19, 2022
|
Merging to see the Slack notification of the deployment 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2044 by @obulat
Description
This PR adds two methods that return a localized search path to the search store:
updateSearchPath- can update the search state (search term and search type) and return the updated path.getSearchPath- can return a path for a search type that's different from the current search type to use, for example, in the content links.Testing Instructions
Try searching for something, updating the search type, changing the search term: the search path should always be updated correctly. Also, if you select some filters on the "All media" search view and click on the Content links (See all images/audio), the new page should have correct URL.
It should work both with the old header and the new one, and for all languages.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin