This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix popover not closing on Escape or click outside #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2036 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
changed the title
openverse-bot
added
♿️ aspect: a11y
|
Size Change: -7.11 kB (-1%) Total Size: 852 kB
ℹ️ View Unchanged
|
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/3648644886 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
zackkrida
approved these changes
Dec 8, 2022
dhruvkb
approved these changes
Dec 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2033 by @zackkrida
Description
The change that moved the focus trap from the VModal component into the useDialog composable failed to account for the fact that Popovers also use it, and don't need a focus trap.
This PR only activates/deactivates the focus trap if the
trapFocusprop is set totrue, and setstrapFocustofalsefor VPopover component.It also adds an e2e test for closing the popover on click outside and pressing Escape to the
homepagee2e test (that's the simplest place where we can open a popover).Testing Instructions
Try running the app on desktop. Open the popovers (content switcher on the homepage, pages menu or content switcher in the header) and check that pressing Escape or clicking outside closes them.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin