-
Notifications
You must be signed in to change notification settings - Fork 63
Prevent pre-commit installation if it exists #2027
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2027 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/3612429828 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect; LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this, Dhruv, it was bothering me, too. Can we merge it now 😉
Fixes
Fixes #1971 by @sarayourfriend
Sorry @jalajk24, but this was getting very annoying for me
Description
This PR prevents pre-commit from being downloaded everytime the dev server is started using
pnpm dev
.Testing Instructions
Run
pnpm dev
. If you do not havepre-commit.pyz
it will be downloaded. If you do have it, the download will be skipped.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin