Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Prevent pre-commit installation if it exists #2027

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 4, 2022

Fixes

Fixes #1971 by @sarayourfriend
Sorry @jalajk24, but this was getting very annoying for me

Description

This PR prevents pre-commit from being downloaded everytime the dev server is started using pnpm dev.

Testing Instructions

Run pnpm dev. If you do not have pre-commit.pyz it will be downloaded. If you do have it, the download will be skipped.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Dec 4, 2022
@dhruvkb dhruvkb requested a review from a team as a code owner December 4, 2022 08:26
@dhruvkb dhruvkb requested review from zackkrida and obulat December 4, 2022 08:26
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2027
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2027/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Playwright Failure Test Results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for both Storybook and Nuxt Playwright tests that have failed at the bottom of this
page, under the "Artifacts" section:

https://github.com/WordPress/openverse-frontend/actions/runs/3612429828

Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect; LGTM.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, Dhruv, it was bothering me, too. Can we merge it now 😉

@obulat obulat removed the 🧰 goal: internal improvement Improvement that benefits maintainers, not users label Dec 6, 2022
@zackkrida zackkrida merged commit dda76e5 into main Dec 6, 2022
@zackkrida zackkrida deleted the no_always_pre_commit branch December 6, 2022 18:26
github-actions bot pushed a commit that referenced this pull request Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only install pre-commit if it isn't already downloaded
4 participants