This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix design mismatch in VMediaLicense
#2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2025 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -3.29 kB (0%) Total Size: 807 kB
ℹ️ View Unchanged
|
zackkrida
approved these changes
Dec 1, 2022
|
The component does exist in the Design Library's License page. The element missed is the link to see the license details. I like the Read more sentence as a solution, but I would follow the popover design instead. The popover shows a "See more about the license" and the style is regular instead of bold.
On the other hand, I noticed an odd gap between the license item and the read more sentence. The spacing is
|
obulat
reviewed
Dec 2, 2022
|
@obulat using I added a Storybook decorator to enable that in f42aa9c. Hopefully this decorator should allow us to test more components that use UI store inside Storybook. |
dhruvkb
force-pushed
the
license_design
branch
2 times, most recently
from
2c68133 to
7721d12
Compare
dhruvkb
force-pushed
the
license_design
branch
from
7721d12 to
6b5446d
Compare
obulat
approved these changes
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #764 by @krysal
Description
This PR
VMediaLicensecomponent as it's more relevant there instead ofVMediaReuse.uppercaseclass to prevent 'CC Sampling+' from being rendered as 'CC SAMPLING+'VLicenseElementssuch as license explanations in the filter sidebarConcern
Since there are no mockups for CC0 or PDM, the design for it looks different from the regular licenses and falls into dangerously into undefined UI terrority, notably the bold "Read more about the tool here" text that's not present in other licenses.
I've left a comment for @panchovm in Figma too and we can update the component (hopefully in a separate issue and PR) if changes are needed.
Testing Instructions
Compare the mockups linked in the issue against the updated components. You should see the spacings and dimensions in the UI match the mockups.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin