-
Notifications
You must be signed in to change notification settings - Fork 63
Update about page to include external sources information #2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are great!
We'll need to update the snapshots for Virtual regression tests. Please let me know if you need any help, or if you want me to update the snapshots, I'd be happy to help!
thx. i`d like to try it myself. i`ll let you know if i have any questions :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snapshots are awesome, thank you, @anton202 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I noticed one discrepancy in the text but we could create an issue to fix that instead of doing it here. I'll leave that up to Olga.
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Fixes
Fixes #1989 by @obulat
Description
This PR adds the external sources page text to about page.
the extrenal sources text in the about page is displayed only if the new header is available.
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin