Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update about page to include external sources information #2000

Merged
merged 10 commits into from
Nov 28, 2022
Merged

Update about page to include external sources information #2000

merged 10 commits into from
Nov 28, 2022

Conversation

anton202
Copy link
Contributor

Fixes

Fixes #1989 by @obulat

Description

This PR adds the external sources page text to about page.
the extrenal sources text in the about page is displayed only if the new header is available.

Testing Instructions

  1. go to the /about page. make sure there is no exteranl source text displayed.
  2. go to /preferences. enable the new header. got to /about page. make sure that the external sources text is displayed

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@anton202 anton202 requested a review from a team as a code owner November 21, 2022 15:36
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Nov 21, 2022
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are great!
We'll need to update the snapshots for Virtual regression tests. Please let me know if you need any help, or if you want me to update the snapshots, I'd be happy to help!

@anton202
Copy link
Contributor Author

anton202 commented Nov 23, 2022

thx. i`d like to try it myself. i`ll let you know if i have any questions :)

@anton202 anton202 mentioned this pull request Nov 24, 2022
7 tasks
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshots are awesome, thank you, @anton202 !

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I noticed one discrepancy in the text but we could create an issue to fix that instead of doing it here. I'll leave that up to Olga.

src/locales/scripts/en.json5 Outdated Show resolved Hide resolved
obulat and others added 2 commits November 28, 2022 13:48
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
@obulat obulat merged commit 2cedd04 into WordPress:main Nov 28, 2022
@anton202 anton202 deleted the update/about_page branch November 30, 2022 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the About page to add the text from "External sources" page
4 participants