Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Screenreaders new tab disclosure #1995

Closed
wants to merge 12 commits into from
Closed

Screenreaders new tab disclosure #1995

wants to merge 12 commits into from

Conversation

AlexVCS
Copy link
Contributor

@AlexVCS AlexVCS commented Nov 18, 2022

Fixes

Fixes WordPress/openverse#496

Description

Adds span tag to VLink.vue and aria-new-tab value to en.json5

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
    ⬆️ Currently I'm getting an error, but I don't think it relates to any of the changes I made.
    image

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added ♿️ aspect: a11y Concerns related to the project's accessibility ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon labels Nov 18, 2022
src/components/VLink.vue Outdated Show resolved Hide resolved
@AlexVCS
Copy link
Contributor Author

AlexVCS commented Nov 24, 2022

I pulled in the changes you made and I also ran

pnpm i18n:watch-en

This is the error message I get when I run that command:

Screen Shot 2022-11-24 at 4 50 24 PM

I still can't get the application running, despite my attempts. Any idea what may be wrong and where I should look to fix it? Thanks

@obulat
Copy link
Contributor

obulat commented Nov 26, 2022

I rebased this PR, too, @AlexVCS. Could you please try running pnpm dev here, too? If you still see errors, maybe you could delete node_modules and re-run pnpm install, and then try pnpm dev once again?

@obulat
Copy link
Contributor

obulat commented Nov 30, 2022

I still can't get the application running, despite my attempts. Any idea what may be wrong and where I should look to fix it? Thanks

I've noticed that your main branch is quite old, its last updated date is more than 3 months ago. This might be the cause for the errors you're getting, @AlexVCS. Please let me know if you need help with updating it.

@krysal
Copy link
Member

krysal commented Dec 22, 2022

@AlexVCS Are you still interested in finishing this work? Just a check-in! It's okay if you don't the capacity right now but we would appreciate you let us know :)

@AlexVCS
Copy link
Contributor Author

AlexVCS commented Jan 2, 2023

@AlexVCS Are you still interested in finishing this work? Just a check-in! It's okay if you don't the capacity right now but we would appreciate you let us know :)

really sorry to respond late! I see that Olga has been making some commits, but if there is anything needed still I would be happy to help

@zackkrida
Copy link
Member

@AlexVCS and @obulat, do you think we should mark this "Ready for Review"?

@obulat
Copy link
Contributor

obulat commented Feb 8, 2023

I am going to close this PR because the simple change is causing line breaks in the snapshots between words and punctuation marks, and the larger changes have grown too much to safely merge.

@obulat obulat closed this Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♿️ aspect: a11y Concerns related to the project's accessibility ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not open external links in new tabs
5 participants