-
Notifications
You must be signed in to change notification settings - Fork 63
Update TypeScript version to 4.9.3 #1993
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1993 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Size Change: +37.1 kB (+5%) 🔍 Total Size: 861 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we'll need to update prettier and eslint (and TypeScript parsers) to get the latest syntaxes like satisfies
etc.
The upstream dependencies have been updated, so I've updated the PR, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested the changes to the focus trap by manually testing the modal behaviour in Storybook.
There's one bit of left over testing code but not blocking so that you're not waiting for a second approval after removing it 👍
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
I just realized (and later tested) that I need to downgrade But I actually really like moving focus trap code inside the composables, that where we handle all the focus handling anyways :) |
Fixes
Fixes #1834 by @sarayourfriend
Description
This PR updates TS to the latest available version.
Testing Instructions
The
types
step in the CI should pass, along with other CI steps.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin