This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Attach ResizeObserver
when component is mounted
#198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #171 by @obulat
Description
This PR defers the initialisation of the
observer
variable to theonMounted
hook which runs on the client where the ResizeObserver API is available.Technical details
The ResizeObserver API is provided by
window
, and thus only exists on the client. Using it in thesetup()
function causes it to be run on the server side of SSR leading to an error. Marking the component as<ClientOnly>
is not an elegant solution.Tests
See reproduction steps on the issue.
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin