Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Attach ResizeObserver when component is mounted #198

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 8, 2021

Fixes

Fixes #171 by @obulat

Description

This PR defers the initialisation of the observer variable to the onMounted hook which runs on the client where the ResizeObserver API is available.

Technical details

The ResizeObserver API is provided by window, and thus only exists on the client. Using it in the setup() function causes it to be run on the server side of SSR leading to an error. Marking the component as <ClientOnly> is not an elegant solution.

Tests

See reproduction steps on the issue.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 8, 2021 14:18
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It works 😄

@zackkrida zackkrida mentioned this pull request Sep 8, 2021
7 tasks
@dhruvkb dhruvkb merged commit e9fd454 into main Sep 8, 2021
@dhruvkb dhruvkb deleted the obs_on_mounted branch September 8, 2021 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ResizeObserver not available for Waveform on SSR
3 participants