This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix "Back to results" link and remove grey background from single results page #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1977 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -2.15 kB (0%) Total Size: 820 kB
ℹ️ View Unchanged
|
obulat
reviewed
Nov 16, 2022
obulat
reviewed
Nov 18, 2022
obulat
reviewed
Nov 18, 2022
There was a problem hiding this comment.
When I checked out this PR, and ran Playwright tests without running pnpm dev first, I get errors locally because the en.json5 was updated, but en.json wasn't.
If we add pnpm run i18n:get-translations --en-only to playwright.sh, we'll always update the generated json file before running the tests.
obulat
reviewed
Nov 18, 2022
obulat
suggested changes
Nov 18, 2022
Co-authored-by: Olga Bulat <obulat@gmail.com>
zackkrida
reviewed
Nov 21, 2022
| @@ -1,10 +1,10 @@ | |||
| <template> | |||
| <!-- @todo: Separate the absolute container from the link itself. --> | |||
| <VLink | |||
| class="flex flex-row items-center px-2 py-3 text-xs font-semibold text-dark-charcoal md:px-6 md:pt-4 md:pb-2 md:text-sr" | |||
| :href="path" | |||
| class="time inline-flex flex-row items-center gap-2 rounded-sm p-2 text-xs font-semibold text-dark-charcoal-70 pe-3 hover:text-dark-charcoal" | |||
There was a problem hiding this comment.
What is the "time" CSS class?
There was a problem hiding this comment.
That's the name of the font styled used by @panchovm in the Figma mockups. If I had to guess, it started as the font-style used in the audio timestamps but then found use in other places without updating the name.
There was a problem hiding this comment.
I think you are referring to the Time pill component. I am seeing the Design Library and that is the only component named like that and used in all audio component's variants.
There was a problem hiding this comment.
I was referring to this:
There was a problem hiding this comment.
Oh, I got it. And yes, it was named time as it was created for the time pill.
zackkrida
suggested changes
Nov 21, 2022
|
Snapshots are great! I can see a couple of problems on the pages:
Although we should select a single threshold breakpoint instead of using I'm not sure if it's best to fix here, or to open separate issues, though. |
obulat
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1974 by @zackkrida
Description
This PR
Testing Instructions
See that the issue #1974 has been resolved, without tampering the old header UI.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin