Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Ignore Storybook files in Prettier #197

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Ignore Storybook files in Prettier #197

merged 2 commits into from
Sep 8, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 8, 2021

Description

Storybook files are ignored in the .gitignore file. But they still cause some Prettier violations when running Prettier directly. This PR ignores them from Prettier as well.

Screenshots

Before:
Screenshot 2021-09-08 at 7 14 32 PM

After:
Screenshot 2021-09-08 at 7 15 35 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 8, 2021 13:46
@dhruvkb dhruvkb requested review from krysal and obulat September 8, 2021 13:46
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, these warnings are overwhelming sometimes.

.prettierignore Outdated Show resolved Hide resolved
Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve>
@dhruvkb dhruvkb merged commit 22012c4 into main Sep 8, 2021
@dhruvkb dhruvkb deleted the prettier_config branch September 8, 2021 20:24
@zackkrida zackkrida added 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants