-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1964 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker-related scripts are a great addition. I'm not so sure about just
but I appreciate the cross-repo consistency and I don't mind it because pnpm run
continues to work.
I find my muscle memory is so strong that every time I come to work on something on the frontend I'm always so surprised I can't use any of my |
Description
This PR adds two docker scripts,
docker:build
anddocker:run
, to the pnpmpackage.json
config. I've also replaced the uses of those docker commands in the README with the associatedpnpm
command.I've also added a
justfile
to this repo sojust
can be used in lieu ofpnpm
. Since we usejust
for our other projects, this can help make the workflow similar to our other projects!Testing Instructions
Run the following:
just
just run docker:build
just run docker:run
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin