This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Refactor VSearchButton #1961
Merged
Refactor VSearchButton #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1961 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
|
Size Change: -2.16 kB (0%) Total Size: 821 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
search-button_refactor
branch
from
f0e23b7 to
ca4c5e3
Compare
obulat
force-pushed
the
search-button_refactor
branch
from
ca4c5e3 to
288a8e8
Compare
dhruvkb
approved these changes
Nov 15, 2022
| @@ -82,3 +85,8 @@ export default defineComponent({ | |||
| }, | |||
| }) | |||
| </script> | |||
There was a problem hiding this comment.
Please add a blank line. Maybe we should add a lint rule that ensures this.
Comment on lines
+53
to
+54
| /* Removes a tiny gap between the button and the input borders */ | ||
| border-inline-start: 0; |
There was a problem hiding this comment.
Seeing as border-inline-* is being used in many places, would making a Tailwind utility for this be cleaner? Looks like that can remove entire <style> blocks in some files.
zackkrida
approved these changes
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1947 by @obulat
Description
There are two components for the Search button: old and new. Currently,
VSearchButtonis used only on the search page with thenew_header. TheVSearchButtonOldis used everywhere else (in the search pages with theold_headerand the standalone search bar on the 404 and home pages)This means that we cannot simply remove the component when we switch to the
new_headeras the standalone search bar would be using it.To solve it, this PR refactors the components. Now, the
VSearchButtonOldis only used on the search pages withold_headerlayout, and can be safely deleted when we switch on thenew_headerflag in production.There are no additional tests, but there are VR tests for the search button on all pages that still pass in this PR, so it means there are no visual regressions.
Testing Instructions
There are many VR tests that test the Search button: on the homepage, on the search page (in the header component tests, hovered/active), and on the 404 page. They did not have to be updated.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin