This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Make Playwright tests less flaky by using storybook to test VMediaReuse #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1946 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
|
Size Change: -226 B (0%) Total Size: 815 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
fix/media_reuse_tests
branch
from
ac92fbb to
f0ee0bb
Compare
obulat
changed the title
obulat
added
🟧 priority: high
sarayourfriend
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Would adding a "wait for" poll to the original tests also have fixed this, potentially, or would it just have moved the flakiness elsewhere?
I've mentioned in the linked issue some things I've tried to fix this problem, but unfortunately, nothing was a permanent solution to flakiness.
I've tried several other options, including waiting for network status and completely blocking the loading of the main image. In addition to not working correctly, they still fail.
dhruvkb
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1945 by @obulat
Description
This PR moves the VMediaReuse tests that test the license attribution tabs to a Storybook test. This makes them much less flaky.
The snapshots are updated, now they don't have a white padding around them:
Testing Instructions
The CI tests should pass.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin