Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Replace deprecated set-output command #1940

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Replace deprecated set-output command #1940

merged 3 commits into from
Dec 14, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 26, 2022

Fixes

Fixes #1937 by @obulat

Description

This PR replaces the outdated set-output command with the recommended value: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands

Testing Instructions

The CI should work

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1940
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1940/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Oct 26, 2022
.github/workflows/ghcr.yml Outdated Show resolved Hide resolved
@obulat obulat marked this pull request as ready for review December 13, 2022 07:29
@obulat obulat requested a review from a team as a code owner December 13, 2022 07:29
@obulat obulat requested review from zackkrida and dhruvkb December 13, 2022 07:29
@WordPress WordPress deleted a comment from github-actions bot Dec 13, 2022
@zackkrida zackkrida changed the title Update to use GITHUB_STATE Replace deprecated set-output command Dec 13, 2022
@zackkrida zackkrida changed the title Replace deprecated set-output command Replace deprecated set-output command Dec 13, 2022
@zackkrida zackkrida requested review from krysal and removed request for dhruvkb December 13, 2022 13:50
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failing tests seems to be an unrelated thing.

obulat and others added 3 commits December 14, 2022 16:30
@obulat obulat force-pushed the update/ghcr_github_state branch from 1941fd5 to 87cc4fa Compare December 14, 2022 14:01
@obulat obulat merged commit f18ff38 into main Dec 14, 2022
@obulat obulat deleted the update/ghcr_github_state branch December 14, 2022 14:31
github-actions bot pushed a commit that referenced this pull request Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command
3 participants