This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Refactor VIconButton and add VSearchBarButton #1921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1921 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -4.96 kB (-1%) Total Size: 819 kB
ℹ️ View Unchanged
|
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/3279169516 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1894 by @obulat
Description
The main goal for this PR is to implement a
VSearchBarButtoncomponent as a wrapper overVIconButtonthat allows setting a separate visible focus area that is smaller than the button, but larger than the icon it contains. This is necessary to match the new header mockups. TheVContentSettingsButton, Back button and the Clear button all need to have a 48x48px tappable area to be accessible on mobile. The inner focus area which has a different color is 32x32px, and the icon size is 24x24px.This PR also audits all the
VIconButtoncomponents and reactors them to use the single numeric value for icon size as theVIconcomponent expects, instead of overriding the icon's size by using a class likew-6 h-6on top of the computed size class. To make sure that all theVIconButtonsizes are possible, we add more sizes to theVIconcomponent.Testing Instructions
You can view the buttons in the Storybook.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin