-
Notifications
You must be signed in to change notification settings - Fork 63
Remove ignore scripts (nuxt requires it) #1905
Conversation
Add another facility to skip the pre-commit installation in environments that do not need it
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1905 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
`bash` appears to be unavailable in CI docker for some reason, despite working fine locally... go figure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
Once the CI passes again whoever gets to this first should merge it 🙂 |
Add another facility to skip the pre-commit installation in environments that do not need it
Fixes
Fixes the staging builds failing
Description
We added
--ignore-scripts
so thatprepare
would be skipped inside Docker. Nuxt and some other dependencies need those scary post-installation, apparently, to make things work so we can't skipprepare
in that way. I've added a different facility for skipping the pre-commit installation in Docker.Testing Instructions
And then make a request to the local server. Before this PR it will fail on an error about reading
use
of undefined. After this PR it will work.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin