This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Combine mobile and desktop search inputs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
changed the title
zackkrida
approved these changes
Apr 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hero section contained two different search text inputs and buttons. They were added to use different bulma/vocabulary styles for both mobile and larger screens. Since we are not going to use vocabulary, removing one of the search inputs and handling the size changes using CSS is a cleaner solution.
This PR also replaces an
h5heading with anh2heading styled as anh5to ensure correct document outline is created for accessibility purposes.