This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Hide the recent searches when navigating with the keyboard #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1889 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🕹 aspect: interface
|
Size Change: -2.52 kB (0%) Total Size: 820 kB
ℹ️ View Unchanged
|
obulat
reviewed
Oct 10, 2022
There was a problem hiding this comment.
This solves the happy path problem, and I really love the size of this PR :)
One issue I found is if you navigate to the 'Clear' button, press Enter while on it, and then press Tab again, the recent searches does not close.
We could add a 'Tab' keydown handler to the Search Button and close the Recent searches if they are open.
|
@obulat since the Recent searches dialog come after the Search button in the tab order, if we always hid the recent searches when Tab is pressed on the Search button, the Clear button would become unreachable. So in f6d01f6 I've set the Search button Tab handler to only hide Recent searches if there are 0 entries. |
I knew there was a caveat! 😆 |
obulat
suggested changes
Oct 10, 2022
|
Should we immediately hide the popup when the 'Clear' button is pressed? That would fix this case. |
I wonder if hiding it after a short delay is better? This way, the users are not surprised when it is closed immediately, and might even have time to see that the list was emptied and that is why the popup closed? |
|
Alternatively, should the |
|
What if we focus the input when clicking the 'Clear' button? Then the user can 1. start typing the new value right away or 2. tab away and close the popover. |
|
@obulat I tried your suggestion (almost verbatim, I realise now) and it works pretty well. The UX is pretty good and functionality-wise it does what one would expect. Thanks! |
obulat
approved these changes
Oct 11, 2022
zackkrida
approved these changes
Oct 11, 2022
dhruvkb
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1886 by @zackkrida
Description
This PR hides the recent searches when the keyboard focus moves past the 'Clear' button in the recent searches dropdown.
Testing Instructions
Screenshots
Screen.Recording.2022-10-07.at.8.48.12.AM.mov
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin