This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update desktop searchbar colors #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1880 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: +1.64 kB (0%) Total Size: 818 kB
ℹ️ View Unchanged
|
zackkrida
suggested changes
Oct 3, 2022
There was a problem hiding this comment.
Looks great, one small error. The hover state is also meant to be the gray background, and the text darkens a bit:
https://www.figma.com/file/GIIQ4sDbaToCfFQyKMvzr8/Openverse-Design-Library?node-id=2960%3A8723
|
obulat
added
🕹 aspect: interface
obulat
force-pushed
the
add/desktop_header_vr_tests
branch
from
8957c2c to
277a79e
Compare
obulat
commented
Oct 4, 2022
| @@ -5,7 +5,8 @@ | |||
| sizeClasses, | |||
| { | |||
| 'max-w-[10rem] sm:max-w-[20rem] md:max-w-[16rem]': isHeaderScrolled, | |||
There was a problem hiding this comment.
This change is not related to the desktop searchbar, but it fixes the homepage: when the desktop search type button is focused, it should be white and should not have a border (it has a pink ring instead).
obulat
force-pushed
the
add/desktop_header_vr_tests
branch
2 times, most recently
from
69084f5 to
51d6323
Compare
zackkrida
approved these changes
Oct 6, 2022
obulat
added
🟧 priority: high
Fix colors for the homepage content switcher (in the searchbar) Fix colors on hover, add active snapshot This header is only used on the search routes, so there's no need for handling non-search routes Add a Clear button, hide it when the search term is blank Import the VClearButton component
obulat
force-pushed
the
add/desktop_header_vr_tests
branch
from
51d6323 to
042ec3e
Compare
dhruvkb
approved these changes
Oct 10, 2022
I feel like it's much easier to safely develop both old and new components when they are separated than to use the flag for styles. It is very easy to accidentally break both :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1879 by @dhruvkb
Description
This PR updates the searchbar colors to match the desktop mockups, and adds the VR tests.
Testing Instructions
The searchbar on the homepage and on the search pages on the desktop widths should match the mockups.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin