Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Perform housekeeping on the main branch #187

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Perform housekeeping on the main branch #187

merged 3 commits into from
Sep 6, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 6, 2021

Description

This PR

  • fixes a file name that was broken during name refactoring Fix casing in filenames #176
  • adds a README.md step for fetching translations
  • updates the .pot file to match the contents of the branch

Technical details

Without these changes the dev server fails to load. This PR fixes that.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 6, 2021 09:50
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching these things, and for the documentation improvements. I definitely want to improve how we set the locales in the nuxt.config.js file—perhaps we can switch to a dynamic import for the JSON file and swallow errors if it isn't present.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should the i18n:get-translations script be included in postinstall?

@dhruvkb dhruvkb merged commit 16fc19c into main Sep 6, 2021
@zackkrida
Copy link
Member

@sarayourfriend I think yes, at least, until we modify things so the locales aren't required to run the application.

@zackkrida zackkrida added the 🧰 goal: internal improvement Improvement that benefits maintainers, not users label Sep 8, 2021
@dhruvkb dhruvkb deleted the main_housekeeping branch September 8, 2021 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants