This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Rename meta search page and all code #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🚦 status: awaiting triage
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1868 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
zackkrida
commented
Sep 27, 2022
zackkrida
commented
Sep 27, 2022
|
Size Change: -7.64 kB (-1%) Total Size: 810 kB
ℹ️ View Unchanged
|
obulat
reviewed
Sep 28, 2022
src/locales/en.json
Outdated
| "new": "For users of the legacy CC Meta Search site, the Meta Search feature on {openverse} will look familiar. The goal was to ensure that the functionality is not lost, but is updated and embedded within our new search engine for openly licensed content. In addition, the Meta Search feature builds on this functionality, allowing us to quickly add new sources to Meta Search as we discover them, and support new content types in the future, as we expand.", | ||
| "content": "For many years, Creative Commons has offered its users a dedicated search portal for searching platforms that have CC licensing filters built in. In fact, this is still maintained at {old}.", | ||
| "old": "oldsearch.creativecommons.org", | ||
| "new": "For users of the legacy CC Meta Search site, the External Sources feature on {openverse} will look familiar. The goal was to ensure that the functionality is not lost, but is updated and embedded within our new search engine for openly licensed content. In addition, the External Sources feature builds on this functionality, allowing us to quickly add new sources to External Sources as we discover them, and support new content types in the future, as we expand.", |
There was a problem hiding this comment.
Not blocking for this PR, but I think this statement is probably not true since we've removed the filters from the External Sources.
obulat
reviewed
Sep 28, 2022
| } | ||
| }, | ||
| "relationships": "This functionality also allows us to start conversations and build relationships with sources that may like to be included in {openverse} in the future. Finally, we can also offer external sources of media types we do not include in {openverse} yet, but plan to.", | ||
| "explanation": "You can find links to external sources at the bottom of every {openverse} search results page; on pages for searches which return no results; and on pages for media types we do not yet support but intend to." |
There was a problem hiding this comment.
Suggested change
| "explanation": "You can find links to external sources at the bottom of every {openverse} search results page; on pages for searches which return no results; and on pages for media types we do not yet support but intend to." | |
| "explanation": "You can find links to external sources at the bottom of every {openverse} search results page, on pages for searches which return no results, and on pages for media types we do not yet support but intend to." |
There was a problem hiding this comment.
Would comma be better here?
obulat
added
🟨 priority: medium
obulat
approved these changes
Sep 28, 2022
obulat
removed
the
🚦 status: awaiting triage
|
Thanks you for updating the snapshots, @obulat! |
dhruvkb
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
These are very welcome changes.
My biggest suggestion is to quote "External Sources" when using it in a sentence as a feature name or to lowercase it and integrate into the sentence otherwise (leaving comments for both such scenarios). It's way too generic a phrase to read on it's own as the name of a feature.
Approving so as not to block.
src/locales/en.json
Outdated
Comment on lines
140
to
141
| "title": "How does the External Sources feature work for indexed media types?", | ||
| "demo-label": "Layout of External Sources for indexed media type, like images", |
There was a problem hiding this comment.
Since "External Sources" is so generic (unlike "Meta Search" which was a proper feature name) maybe we should quote it when using in sentences.
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
|
@WordPress/openverse-frontend Could someone help me here? I merged in
|
|
I'm able to run them locally, but it seems like it might be the build timing out for you based on the small logs you shared. Can you share the full build logs for you locally? They do run in CI as well, so I'd be surprised if it's a build performance issue given how small the CI boxes are compared to our local machines. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1197
Description
Renames meta search everywhere and improves + simplifies the page copy.
Testing Instructions
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin