Refactor PhotoDetails component to facilitate adding other media types

[obulat]

Fixes

Fixes #179 by @obulat

Description

This PR extracts common functionality mainly related to license and attribution from ImageDetail components to make them usable with other media types.

Technical details

Some functions related to license handling are extracted to utils/license.js. It would be nice to find a better home than utils in the future.
Some spacing and font sizes need to be fixed to match the designs.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

This is a great idea. Thanks for doing this!

[sarayourfriend]

This is cool! Tested locally and it seems to work well 🚀

[sarayourfriend]

I wonder if this would be clearer if the function was isPublicDomainLicense or something like that?

[zackkrida]

Something like:

export const isLicense = (licenseOrMark = '') => {
  return !['pdm', 'cc0'].includes(licenseOrMark.toLowerCase())
} 

export const isPublicDomain = (licenseOrMark = '') => {
  return ['pdm', 'cc0'].includes(licenseOrMark.toLowerCase())
} 

might be a bit clearer? just one approach, i'm sure there's better.

[sarayourfriend]

isLicense is confusing to me, but maybe it's a domain knowledge issue. Isn't CC0 and PDM still a "license" even it's public domain?

[zackkrida]

Isn't CC0 and PDM still a "license" even it's public domain?

No actually! they are just "marks" or "designations", not licenses in the legal sense. CC even explains this quite poorly, admittedly. That's the purpose of this function, to determine if something is a license or a mark, so that front-end language can be changed.

Boring legal details: https://wiki.creativecommons.org/wiki/CC0_FAQ#What_is_CC0.3F

[sarayourfriend]

Oh cool, that's good to know! Thanks for the explanation. In that case my comment doesn't really matter 🙂 Maybe we could add a link to that wiki page in the @see for the function to document for future contributors?

[zackkrida]

that's a great suggestion

[obulat]

Great question @sarayourfriend , and thank you for explanations, @zackkrida !
The CC Website has the following wording for its mission: "Provide Creative Commons licenses and public domain tools ...".
I love the isPublicDomain function name, but would isPDTool be more correct in legal terms? I suppose that having a comment about difference between Licenses and Public Domain tools would be enough, though.

[sarayourfriend]

LGTM!