This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add load more button e2e tests #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1793 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
|
Size Change: -1.2 kB (0%) Total Size: 802 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
add/load-more-e2e-tests
branch
2 times, most recently
from
6ed0a5f to
3d97d77
Compare
|
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
dhruvkb
approved these changes
Sep 15, 2022
| * - should have a Load more button. | ||
| * - when button is clicked, should fetch only images. | ||
| * - image view should have a Load more button. | ||
| */ |
There was a problem hiding this comment.
Although it is unlikely to differ in behaviour, but for completeness' sake, we should add the opposite of cases 2 and 3 where audio results are more than image.
There was a problem hiding this comment.
I agree, but I couldn't find an example search term for that 😆 I guess I should mock the response.
zackkrida
approved these changes
Sep 16, 2022
Comment on lines
+30
to
+44
| /** | ||
| * Cases, check both SSR and CSR: | ||
| * 1. All content view with more than 1 page of results for each media type: | ||
| * - should have a Load more button. | ||
| * - each individual media type view should have a Load more button. | ||
| * - when button is clicked, should fetch all media types. | ||
| * 2. All content view with results for images, but only 1 page of results for audio: | ||
| * - should have a Load more button. | ||
| * - when button is clicked, should fetch only images. | ||
| * - image view should have a Load more button, but audio view should not. | ||
| * 3. All content view with results for images, but no results for audio: | ||
| * - should have a Load more button. | ||
| * - when button is clicked, should fetch only images. | ||
| * - image view should have a Load more button. | ||
| */ |
| } | ||
| } | ||
| }) | ||
| await goToSearchTerm(page, 'horses snort', { mode }) |
Co-authored-by: Zack Krida <zackkrida@pm.me>
obulat
force-pushed
the
add/load-more-e2e-tests
branch
from
c8954ea to
72c92e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1788 by @obulat
Description
This PR adds the e2e tests for load more functionality. They should fail on main, but pass after #1786 is merged.
Testing Instructions
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin