Fix iframe infinite height increase issue

[zackkrida]

Fixes

Fixes WordPress/openverse#56 by @zackkrida

Description

This PR fixes the iframe height infinite increase issue by removing 100vh from the height of the sidebar, which was previously used to determine the height of the filter sidebar. This makes the filter sidebar content no longer sticky, but because these are interim styles anyway I think it is okay. In the future we'll need to experiment with 100vh within the iframe, perhaps replacing it with the browser window height in pixels passed down from the parent.

Technical details

Tests

Screenshots

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

LGTM!

[dhruvkb]

LGTM, appreciate the test page!

[dhruvkb]

A comment explaining the calculation behind 84px would be nice for future reference.

[zackkrida]

these are lines that were removed 😄 otherwise i'd agree!