This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix lint staged to match pnpm:fix order and settings #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
the
🚦 status: awaiting triage
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1761 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
zackkrida
changed the title
obulat
added
🟧 priority: high
obulat
reviewed
Aug 31, 2022
There was a problem hiding this comment.
I couldn't resist looking more into this situation :)
Since we are already running prettier --write, we do not need eslint to check for prettier errors (and un-do the prettier fixes while doing that!). We can actually fix this whole thing if we add "prettier/prettier": "off" to the rules in .eslintrc.js.
Also, I re-arranged the commands in this file locally:
{
"*.{json,yml,yaml,mdx,md}": "prettier --write",
"*.{ts,js,vue}": ["prettier --write", "eslint --ext .js,.vue,.ts --ignore-path .gitignore --ignore-path .eslintignore --max-warnings=0 ."],
}
If two commands are in a bracketed list, they are executed sequentially. The two separate commands in this object are executed at the same time.
And tried committing the VSkipToContainer file with the wrong order of classes:
class="ms-2 z-50 mt-2 focus:fixed focus:absolute".
lintstaged first ran prettier and fixed the class order to the correct class="z-50 mt-2 ms-2 focus:fixed focus:absolute", and then eslint did not undo it. So, husky said that it's an empty commit and refused to commit it :)
Co-authored-by: Olga Bulat <obulat@gmail.com>
|
Fantastic, thanks @obulat! I implemented your suggestions. |
|
Size Change: -381 B (0%) Total Size: 768 kB
ℹ️ View Unchanged
|
krysal
approved these changes
Aug 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1658 by @dhruvkb
Description
Fixes a discrepancy between
pnpm lint:fixand our precommit linting script. Now they run eslint and prettier formatting in the same order with the same settings.