Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Audio label fixed #1651

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Audio label fixed #1651

merged 1 commit into from
Aug 18, 2022

Conversation

ramadanomar
Copy link
Contributor

@ramadanomar ramadanomar commented Aug 11, 2022

Fixes

Fixes #1436 by @zackkrida

Description

Changes text size based on screen size + Adds a padding to smaller displays to stop text from connecting to black play button.

AudioLabelFixed

Testing Instructions

Go to any audio search result list in Chrome and hover a Jamendo or Freesound result, on a small-ish > 1000px browser width

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@ramadanomar ramadanomar requested a review from a team as a code owner August 11, 2022 20:06
@ramadanomar ramadanomar requested review from krysal and dhruvkb August 11, 2022 20:06
@openverse-bot openverse-bot added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Aug 11, 2022
@obulat obulat changed the title Audio Label Fixed Audio label fixed Aug 12, 2022
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better, thank you!

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue, @ramadanomar!

@obulat obulat merged commit f71f32f into WordPress:main Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio seeking warning in Chrome displays poorly on small displays
4 participants