This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Delete Browser Extension page and associated resources #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1649 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: -39.9 kB (-3%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
The images for this page can also be deleted—I'll draft this until I do that. |
|
@zackkrida, you will need to rebase onto main. This branch is in a really weird state where it's using a change (the import path for |
zackkrida
force-pushed
the
delete-extension-page
branch
from
c8ed915 to
d5095b8
Compare
zackkrida
changed the title
obulat
suggested changes
Aug 17, 2022
obulat
added
🟨 priority: medium
|
@obulat nice find, thank you! |
obulat
approved these changes
Aug 17, 2022
zackkrida
force-pushed
the
delete-extension-page
branch
from
8574357 to
c160b93
Compare
|
Rebased to include the changes from #1644 and will merge once CI passes. |
|
There's some difference in the spacing between paragraphs on the sources page. This is causing the visual regression tests to fail. |
obulat
force-pushed
the
delete-extension-page
branch
from
c160b93 to
22c7119
Compare
obulat
reviewed
Aug 18, 2022
| @@ -3,7 +3,7 @@ | |||
| <slot /> | |||
| <VTeleport to="skip-to-content"> | |||
| <VButton | |||
| class="ms-2 z-50 mt-2 focus:fixed focus:absolute" | |||
| class="z-50 mt-2 ms-2 focus:fixed focus:absolute" | |||
There was a problem hiding this comment.
I really don't understand why here it doesn't raise a linting error!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1648 by @zackkrida
Description
Deletes the browser extension page, navigation link, and associated translation strings.
Testing Instructions
Make sure all tests and CI pass, and view the site locally to observe the page is gone.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin